From: Sinan Kaya <okaya@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [RFC] PCI: add support for Immediate Readiness
Date: Wed, 5 Sep 2018 09:54:10 -0700 [thread overview]
Message-ID: <f837db48-065f-4394-5512-a74716a52e8e@kernel.org> (raw)
In-Reply-To: <20180905164909.GJ107892@bhelgaas-glaptop.roam.corp.google.com>
On 9/5/2018 9:49 AM, Bjorn Helgaas wrote:
> pci_dev_wait() is connected with CRS. There's some reason that
> function doesn't actually looks for CRS responses, which I can't
> remember right now. But you can look it up in the changelogs.
>
We wanted to be able to support virtual functions (that can't read
vendor id) as well as systems without CRS visibility support. That
was the reason why we are polling a well known register such as
command status against ~0 rather than the vendor id register.
> So I don't think we should put the Immediate Readiness check in
> pci_dev_wait().
I agree, it should be outside of pci_dev_wait()
next prev parent reply other threads:[~2018-09-05 16:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 11:36 [RFC] PCI: add support for Immediate Readiness Felipe Balbi
2018-08-02 11:56 ` Christoph Hellwig
2018-08-02 12:11 ` Felipe Balbi
2018-08-03 6:14 ` Sinan Kaya
2018-08-03 6:26 ` Felipe Balbi
2018-08-03 17:25 ` Sinan Kaya
2018-09-04 18:11 ` Bjorn Helgaas
2018-09-05 5:18 ` Felipe Balbi
2018-09-05 5:23 ` Felipe Balbi
2018-09-05 5:29 ` Felipe Balbi
2018-09-05 16:49 ` Bjorn Helgaas
2018-09-05 16:54 ` Sinan Kaya [this message]
2018-09-06 6:02 ` Felipe Balbi
2018-09-06 14:13 ` Bjorn Helgaas
2018-09-07 6:16 ` [PATCH v2] " Felipe Balbi
2018-09-20 6:12 ` Felipe Balbi
2018-09-28 17:57 ` Bjorn Helgaas
2018-10-01 5:42 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f837db48-065f-4394-5512-a74716a52e8e@kernel.org \
--to=okaya@kernel.org \
--cc=bhelgaas@google.com \
--cc=felipe.balbi@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).