Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<x86@kernel.org>,
	"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<linux-kernel@vger.kernel.org>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	Aaron Ma <aaron.ma@canonical.com>
Subject: Re: [PATCH v2] x86/video: Only fall back to vga_default_device() without screen info
Date: Mon, 6 Jul 2026 23:47:48 -0500	[thread overview]
Message-ID: <f87df9b4-fd6e-45c3-aea7-e76a7995c050@kernel.org> (raw)
In-Reply-To: <20260707041852.GBakx-LFXxLiouBLwg@fat_crate.local>

On 7/6/26 23:18, Borislav Petkov wrote:
> On Mon, Jul 06, 2026 at 11:02:04PM -0500, Mario Limonciello wrote:
>> Those systems use the existing boot_vga sysfs file (which is unchanged).
>>
>> Userspace recognizes both boot_vga for those systems and boot_display for
>> modern systems depending upon the use.
> 
> You're "explaining" as if I were someone who actually knows anything about
> display gunk. But you need to dumb it down for me so that I can actually
> understand why we're fine here and we don't need to fallback to
> vga_default_device() here, as the LLM has "inferred".
> 
> Thx.
> 

OK, let me try.

So a long time ago there was this sysfs attribute introduced for telling 
which device in the system was used for displaying pre-OS.  It mattered 
when you had multi GPU systems.

It wasn't perfect, but there were enough heuristics put in place that it 
was good enough.

Userspace would take this as a hint and try to set what it thought was 
the primary GPU.  This has implications for power consumption, what is 
used for rendering, all sorts of stuff.

Well the heuristics started to break when we started having display 
adapters that were no longer VGA and those were in multi GPU systems.

Rather than change the heuristics for boot_vga we introduced a new 
attribute boot_display that indicated which device was used for 
displaying.  This is semantically very similar to boot_vga; but it can 
apply to any display adapter.

Because userspace has used boot_vga forever and boot_display was new 
userspace effectively has to support both for two reasons:

1) so that users can mix and match kernels and userspace
2) For the ancient hardware the LLM is complaining about.

So my point here is that even if boot_display fails to be populated on 
anything in your system (such as reasons the LLM called out) you will 
still have boot_vga, and userspace still uses boot_vga.


  reply	other threads:[~2026-07-07  4:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23 14:15 [PATCH v2] x86/video: Only fall back to vga_default_device() without screen info Mario Limonciello
2026-06-23 14:21 ` sashiko-bot
2026-06-23 14:25   ` Mario Limonciello
2026-06-24  6:08 ` Thomas Zimmermann
2026-06-24  6:09 ` Thomas Zimmermann
2026-06-24  8:45 ` Aaron Ma
2026-06-25 22:58   ` Mario Limonciello
2026-07-06 17:47     ` Mario Limonciello
2026-07-07  3:56       ` Borislav Petkov
2026-07-07  4:02         ` Mario Limonciello
2026-07-07  4:18           ` Borislav Petkov
2026-07-07  4:47             ` Mario Limonciello [this message]
2026-07-07  5:01               ` Borislav Petkov
2026-07-07 12:52                 ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f87df9b4-fd6e-45c3-aea7-e76a7995c050@kernel.org \
    --to=superm1@kernel.org \
    --cc=aaron.ma@canonical.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox