From: Matthias Brugger <mbrugger@suse.com>
To: Conor Dooley <conor@kernel.org>, Hal Feng <hal.feng@starfivetech.com>
Cc: "Conor Dooley" <conor+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <pjw@kernel.org>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Emil Renner Berthing" <emil.renner.berthing@canonical.com>,
"Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>,
"E Shattow" <e@freeshell.de>,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/6] PCI: starfive: Use regulator APIs instead of GPIO APIs to enable the 3V3 power supply of PCIe slots
Date: Sat, 6 Dec 2025 13:37:58 +0100 [thread overview]
Message-ID: <f9cc4a7e-c71a-439f-9e71-8cba4986ceb7@suse.com> (raw)
In-Reply-To: <20251125-encourage-junkie-f80e6933b3af@spud>
On 25/11/25 21:00, Conor Dooley wrote:
> On Tue, Nov 25, 2025 at 03:55:59PM +0800, Hal Feng wrote:
>> The "enable-gpio" property is not documented in the dt-bindings and
>> using GPIO APIs is not a standard method to enable or disable PCIe
>> slot power, so use regulator APIs to replace them.
>>
>> Tested-by: Matthias Brugger <mbrugger@suse.com>
>
> Is this actually a valid tag?
> He provided one for the series on v3, which didn't include this patch.
>
No it is not. As I only tested v3. But I was able to test v4 as well, so
for the whole series:
Tested-by: Matthias Brugger <mbrugger@suse.com>
Regards,
Matthias
next prev parent reply other threads:[~2025-12-06 12:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 7:55 [PATCH v4 0/6] Add support for StarFive VisionFive 2 Lite board Hal Feng
2025-11-25 7:55 ` [PATCH v4 1/6] PCI: starfive: Use regulator APIs instead of GPIO APIs to enable the 3V3 power supply of PCIe slots Hal Feng
2025-11-25 20:00 ` Conor Dooley
2025-12-06 12:37 ` Matthias Brugger [this message]
2025-12-01 6:45 ` Hal Feng
2025-12-01 20:52 ` Bjorn Helgaas
2025-12-02 1:45 ` 回复: " Kevin Xie
2025-12-02 3:02 ` Kevin Xie
2025-12-02 3:16 ` Kevin Xie
2025-12-02 16:31 ` Bjorn Helgaas
2025-12-04 13:19 ` Hal Feng
2025-12-02 3:38 ` Hal Feng
2025-11-25 7:56 ` [PATCH v4 2/6] dt-bindings: riscv: Add StarFive JH7110S SoC and VisionFive 2 Lite board Hal Feng
2025-11-25 7:56 ` [PATCH v4 3/6] riscv: dts: starfive: jh7110-common: Move out some nodes to the board dts Hal Feng
2025-11-25 7:56 ` [PATCH v4 4/6] riscv: dts: starfive: Add common board dtsi for VisionFive 2 Lite variants Hal Feng
2025-12-04 17:05 ` Anand Moon
2025-12-05 7:23 ` Maud Spierings
2025-12-05 7:30 ` E Shattow
2025-12-05 7:41 ` Hal Feng
2025-12-05 8:01 ` Anand Moon
2025-11-25 7:56 ` [PATCH v4 5/6] riscv: dts: starfive: Add VisionFive 2 Lite board device tree Hal Feng
2025-11-26 1:44 ` E Shattow
2025-11-25 7:56 ` [PATCH v4 6/6] riscv: dts: starfive: Add VisionFive 2 Lite eMMC " Hal Feng
2025-11-26 1:45 ` E Shattow
2025-11-25 22:24 ` (subset) [PATCH v4 0/6] Add support for StarFive VisionFive 2 Lite board Conor Dooley
2025-12-19 8:09 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9cc4a7e-c71a-439f-9e71-8cba4986ceb7@suse.com \
--to=mbrugger@suse.com \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=e@freeshell.de \
--cc=emil.renner.berthing@canonical.com \
--cc=hal.feng@starfivetech.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox