From: Sinan Kaya <okaya@kernel.org>
To: Sean V Kelley <sean.v.kelley@intel.com>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: Yicong Yang <yangyicong@hisilicon.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] PCI/ASPM: Print correct ASPM status when _OSC failed
Date: Wed, 3 Jun 2020 00:48:04 -0400 [thread overview]
Message-ID: <faaf2c47-6039-74fb-e5d2-91a5b3705459@kernel.org> (raw)
In-Reply-To: <B2282A82-EEA4-40F8-B7F5-1D7AE7E3B573@intel.com>
On 6/2/2020 7:21 PM, Sean V Kelley wrote:
Thanks,
>> - dev_info(&device->dev, "_OSC failed (%s)%s\n",
>> - acpi_format_exception(status),
>> - pcie_aspm_support_enabled() ? "; disabling ASPM" : "");
>> + dev_info(&device->dev, "_OSC: platform retains control of
>> PCIe features (%s)\n",
>> + acpi_format_exception(status));
>> return;
>> }
>>
>> @@ -516,7 +515,7 @@ static void negotiate_os_control(struct
>> acpi_pci_root *root, int *no_aspm,
>> } else {
>> decode_osc_control(root, "OS requested", requested);
>> decode_osc_control(root, "platform willing to grant", control);
>> - dev_info(&device->dev, "_OSC failed (%s); disabling ASPM\n",
>> + dev_info(&device->dev, "_OSC: platform retains control of
>> PCIe features (%s)\n",
>> acpi_format_exception(status));
>>
>
feel free to include my reviewed by.
Reviewed-by: Sinan Kaya <okaya@kernel.org>
next prev parent reply other threads:[~2020-06-03 4:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 8:38 [PATCH] PCI/ASPM: Print correct ASPM status when _OSC failed Yicong Yang
2020-05-28 11:42 ` Rafael J. Wysocki
2020-06-01 15:14 ` Sinan Kaya
2020-06-01 15:22 ` Rafael J. Wysocki
2020-06-02 1:57 ` Yicong Yang
2020-06-02 17:50 ` Sinan Kaya
2020-06-02 22:36 ` Bjorn Helgaas
2020-06-02 23:21 ` Sean V Kelley
2020-06-03 4:48 ` Sinan Kaya [this message]
[not found] ` <03d2a6ca-78de-2d39-5428-2949c2017099@hisilicon.com>
2020-06-03 13:02 ` [PATCH v2] ACPI: PCI: Remove ASPM text from _OSC failure message Rafael J. Wysocki
2020-06-03 13:19 ` Yicong Yang
2020-06-03 12:59 ` [PATCH] PCI/ASPM: Print correct ASPM status when _OSC failed Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faaf2c47-6039-74fb-e5d2-91a5b3705459@kernel.org \
--to=okaya@kernel.org \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sean.v.kelley@intel.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).