From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2444C433E1 for ; Wed, 3 Jun 2020 04:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B905F2081A for ; Wed, 3 Jun 2020 04:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591159688; bh=AphOIH+6/GvyTneJ0nSOFmpaZ59ec5x3izoW69DhFeE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=zmJC6KsS/Di8nBnJTntlZkOmzrpmNuS0iKjJ6gOg0fQb7ZRHzatMvpGa7XSqIQes5 BrUAekNhsFiQP2G+GiKvdnPUQ+VfeCNM5MhPUE5YguwJEWajjYv2+q6Q8WZwmfzDCh AboiTe2ceXSp0z10dHWmA4mgZJUfqhlE+7GfIiRM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725867AbgFCEsI (ORCPT ); Wed, 3 Jun 2020 00:48:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:51346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725275AbgFCEsH (ORCPT ); Wed, 3 Jun 2020 00:48:07 -0400 Received: from [192.168.68.109] (75-58-59-55.lightspeed.rlghnc.sbcglobal.net [75.58.59.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21F2F20659; Wed, 3 Jun 2020 04:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591159686; bh=AphOIH+6/GvyTneJ0nSOFmpaZ59ec5x3izoW69DhFeE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=l/aYsdB+rRcGwHkyRN59EyKAvQL/uZlLu8xldmNf3Wc7qYrcl8zTaOyfsJml7UsZ3 Ok9vkWgpuQJqWJh3hqWiOrdJfvgZcocrElW8mNVGf2d+dm0pJIIFJRa+J5vcKz+rRF anA0Dh8yET8tV6mNSBsF1R6d7BIQcNUH8Is59wlg= Subject: Re: [PATCH] PCI/ASPM: Print correct ASPM status when _OSC failed To: Sean V Kelley , Bjorn Helgaas Cc: Yicong Yang , "Rafael J. Wysocki" , "Rafael J. Wysocki" , Linux PCI , ACPI Devel Maling List , Linuxarm References: <20200602223618.GA845676@bjorn-Precision-5520> From: Sinan Kaya Autocrypt: addr=okaya@kernel.org; keydata= mQENBFrnOrUBCADGOL0kF21B6ogpOkuYvz6bUjO7NU99PKhXx1MfK/AzK+SFgxJF7dMluoF6 uT47bU7zb7HqACH6itTgSSiJeSoq86jYoq5s4JOyaj0/18Hf3/YBah7AOuwk6LtV3EftQIhw 9vXqCnBwP/nID6PQ685zl3vH68yzF6FVNwbDagxUz/gMiQh7scHvVCjiqkJ+qu/36JgtTYYw 8lGWRcto6gr0eTF8Wd8f81wspmUHGsFdN/xPsZPKMw6/on9oOj3AidcR3P9EdLY4qQyjvcNC V9cL9b5I/Ud9ghPwW4QkM7uhYqQDyh3SwgEFudc+/RsDuxjVlg9CFnGhS0nPXR89SaQZABEB AAG0HVNpbmFuIEtheWEgPG9rYXlhQGtlcm5lbC5vcmc+iQFOBBMBCAA4FiEEYdOlMSE+a7/c ckrQvGF4I+4LAFcFAlztcAoCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQvGF4I+4L AFfidAf/VKHInxep0Z96iYkIq42432HTZUrxNzG9IWk4HN7c3vTJKv2W+b9pgvBF1SmkyQSy 8SJ3Zd98CO6FOHA1FigFyZahVsme+T0GsS3/OF1kjrtMktoREr8t0rK0yKpCTYVdlkHadxmR Qs5xLzW1RqKlrNigKHI2yhgpMwrpzS+67F1biT41227sqFzW9urEl/jqGJXaB6GV+SRKSHN+ ubWXgE1NkmfAMeyJPKojNT7ReL6eh3BNB/Xh1vQJew+AE50EP7o36UXghoUktnx6cTkge0ZS qgxuhN33cCOU36pWQhPqVSlLTZQJVxuCmlaHbYWvye7bBOhmiuNKhOzb3FcgT7kBDQRa5zq1 AQgAyRq/7JZKOyB8wRx6fHE0nb31P75kCnL3oE+smKW/sOcIQDV3C7mZKLf472MWB1xdr4Tm eXeL/wT0QHapLn5M5wWghC80YvjjdolHnlq9QlYVtvl1ocAC28y43tKJfklhHiwMNDJfdZbw 9lQ2h+7nccFWASNUu9cqZOABLvJcgLnfdDpnSzOye09VVlKr3NHgRyRZa7me/oFJCxrJlKAl 2hllRLt0yV08o7i14+qmvxI2EKLX9zJfJ2rGWLTVe3EJBnCsQPDzAUVYSnTtqELu2AGzvDiM gatRaosnzhvvEK+kCuXuCuZlRWP7pWSHqFFuYq596RRG5hNGLbmVFZrCxQARAQABiQEfBBgB CAAJBQJa5zq1AhsMAAoJELxheCPuCwBX2UYH/2kkMC4mImvoClrmcMsNGijcZHdDlz8NFfCI gSb3NHkarnA7uAg8KJuaHUwBMk3kBhv2BGPLcmAknzBIehbZ284W7u3DT9o1Y5g+LDyx8RIi e7pnMcC+bE2IJExCVf2p3PB1tDBBdLEYJoyFz/XpdDjZ8aVls/pIyrq+mqo5LuuhWfZzPPec 9EiM2eXpJw+Rz+vKjSt1YIhg46YbdZrDM2FGrt9ve3YaM5H0lzJgq/JQPKFdbd5MB0X37Qc+ 2m/A9u9SFnOovA42DgXUyC2cSbIJdPWOK9PnzfXqF3sX9Aol2eLUmQuLpThJtq5EHu6FzJ7Y L+s0nPaNMKwv/Xhhm6Y= Message-ID: Date: Wed, 3 Jun 2020 00:48:04 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 6/2/2020 7:21 PM, Sean V Kelley wrote: Thanks, >> -        dev_info(&device->dev, "_OSC failed (%s)%s\n", >> -             acpi_format_exception(status), >> -             pcie_aspm_support_enabled() ? "; disabling ASPM" : ""); >> +        dev_info(&device->dev, "_OSC: platform retains control of >> PCIe features (%s)\n", >> +             acpi_format_exception(status)); >>          return; >>      } >> >> @@ -516,7 +515,7 @@ static void negotiate_os_control(struct >> acpi_pci_root *root, int *no_aspm, >>      } else { >>          decode_osc_control(root, "OS requested", requested); >>          decode_osc_control(root, "platform willing to grant", control); >> -        dev_info(&device->dev, "_OSC failed (%s); disabling ASPM\n", >> +        dev_info(&device->dev, "_OSC: platform retains control of >> PCIe features (%s)\n", >>              acpi_format_exception(status)); >> > feel free to include my reviewed by. Reviewed-by: Sinan Kaya