From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 996F9C433DF for ; Tue, 25 Aug 2020 04:21:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82CA020737 for ; Tue, 25 Aug 2020 04:21:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726066AbgHYEVF (ORCPT ); Tue, 25 Aug 2020 00:21:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:36106 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725263AbgHYEVF (ORCPT ); Tue, 25 Aug 2020 00:21:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 43412B78E; Tue, 25 Aug 2020 04:21:34 +0000 (UTC) Subject: Re: [patch RFC 24/38] x86/xen: Consolidate XEN-MSI init To: Thomas Gleixner , LKML Cc: x86@kernel.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-hyperv@vger.kernel.org, Haiyang Zhang , Jon Derrick , Lu Baolu , Wei Liu , "K. Y. Srinivasan" , Stephen Hemminger , Steve Wahl , Dimitri Sivanich , Russ Anderson , linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Boris Ostrovsky , Stefano Stabellini , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Megha Dey , Jason Gunthorpe , Dave Jiang , Alex Williamson , Jacob Pan , Baolu Lu , Kevin Tian , Dan Williams References: <20200821002424.119492231@linutronix.de> <20200821002947.667887608@linutronix.de> <5caec213-8f56-9f12-34db-a29de8326f95@suse.com> <87tuwr68q8.fsf@nanos.tec.linutronix.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 25 Aug 2020 06:21:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <87tuwr68q8.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 24.08.20 23:21, Thomas Gleixner wrote: > On Mon, Aug 24 2020 at 06:59, Jürgen Groß wrote: >> On 21.08.20 02:24, Thomas Gleixner wrote: >>> +static __init void xen_setup_pci_msi(void) >>> +{ >>> + if (xen_initial_domain()) { >>> + x86_msi.setup_msi_irqs = xen_initdom_setup_msi_irqs; >>> + x86_msi.teardown_msi_irqs = xen_teardown_msi_irqs; >>> + x86_msi.restore_msi_irqs = xen_initdom_restore_msi_irqs; >>> + pci_msi_ignore_mask = 1; >> >> This is wrong, as a PVH initial domain shouldn't do the pv settings. >> >> The "if (xen_initial_domain())" should be inside the pv case, like: >> >> if (xen_pv_domain()) { >> if (xen_initial_domain()) { >> ... >> } else { >> ... >> } >> } else if (xen_hvm_domain()) { >> ... > > I still think it does the right thing depending on the place it is > called from, but even if so, it's completely unreadable gunk. I'll fix > that proper. The main issue is that xen_initial_domain() and xen_pv_domain() are orthogonal to each other. So xen_initial_domain() can either be true for xen_pv_domain() (the "classic" pv dom0) or for xen_hvm_domain() (the new PVH dom0). Juergen