Re: [PATCH v9 4/7] PCI/DPC: Unify and plumb error handling into DPC

[Randy Dunlap <rdunlap@infradead.org>]

On 02/21/2018 11:46 PM, Oza Pawandeep wrote:
> Current DPC driver does not do recovery, e.g. calling end-point's driver's
> callbacks, which sanitize the sw.
> 
> DPC driver implements link_reset callback, and calls pci_do_recovery.

Hi,
What does DPC mean?

> Signed-off-by: Oza Pawandeep <poza@codeaurora.org>
> 

> diff --git a/drivers/pci/pcie/pcie-dpc.c b/drivers/pci/pcie/pcie-dpc.c
> index 38e40c6..208b427 100644
> --- a/drivers/pci/pcie/pcie-dpc.c
> +++ b/drivers/pci/pcie/pcie-dpc.c

> @@ -82,12 +137,25 @@ static void dpc_wait_link_inactive(struct dpc_dev *dpc)
>  		dev_warn(dev, "Link state not disabled for DPC event\n");
>  }
>  
> +/**
> + * dpc_reset_link - reset link DPC  routine
 + * @dev: pointer to Root Port's pci_dev data structure

   * @pdev: ...

> + *
> + * Invoked by Port Bus driver when performing link reset at Root Port.
> + */
> +static pci_ers_result_t dpc_reset_link(struct pci_dev *pdev)
>  {

You can use 'make W=1 ...' to find kernel-doc warnings like this.

thanks,
-- 
~Randy