From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71836C7EE24 for ; Mon, 8 May 2023 16:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233910AbjEHQm2 (ORCPT ); Mon, 8 May 2023 12:42:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233677AbjEHQm1 (ORCPT ); Mon, 8 May 2023 12:42:27 -0400 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98DFF6E99; Mon, 8 May 2023 09:42:10 -0700 (PDT) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 348GWNCF002890; Mon, 8 May 2023 16:41:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=y9k6cQ4XhKrREyuDzPR2T7/dwcXkNsntOxPMN4zeeQQ=; b=CX0nxLwuGz0tx05tSPYVmIdsV/z82ema42hWuN5R7PILkNWielMzHG2wz3H1h1m/ivaf ABSC2wcH2bu6TVxRkfeMY73hlAF2b4BKVEmvpEoVnJyRD9C5IrqTSBl+tMaEF7GolGmT /I/4AjKfrRCmNknQ3SR9kGYt+Pe0odkC/W6I+ZkjUGn9vtnxup+WXKkvRjBE8V2LRWIi Ec1qpqVRkdWgfNRVVOfk5AQfdRPb5TP/wtLbveKBAZM5iaYvcXaw40M/z2fSJRxHZHx4 TrJ/K6CcQZUOJUI0JZ6Osq/obMsUWPUKScTl3+rLgUb37fzyDIrvNGIrPbjQHjuKMlMF Dw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qf4pj0bgd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 May 2023 16:41:36 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 348GWViJ003580; Mon, 8 May 2023 16:41:36 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qf4pj0bfk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 May 2023 16:41:36 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3482spTc019017; Mon, 8 May 2023 16:41:34 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3qde5fh8bd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 May 2023 16:41:33 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 348GfVAj36634998 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 8 May 2023 16:41:31 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 629B620043; Mon, 8 May 2023 16:41:31 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 74F7B20040; Mon, 8 May 2023 16:41:30 +0000 (GMT) Received: from [9.171.75.120] (unknown [9.171.75.120]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 8 May 2023 16:41:30 +0000 (GMT) Message-ID: Subject: Re: [PATCH v3 30/38] sound: add HAS_IOPORT dependencies From: Niklas Schnelle To: Takashi Iwai Cc: Arnd Bergmann , Jaroslav Kysela , Takashi Iwai , Greg Kroah-Hartman , Bjorn Helgaas , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , alsa-devel@alsa-project.org Date: Mon, 08 May 2023 18:41:30 +0200 In-Reply-To: <87y1nzbji8.wl-tiwai@suse.de> References: <20230314121216.413434-1-schnelle@linux.ibm.com> <20230314121216.413434-31-schnelle@linux.ibm.com> <87y1nzbji8.wl-tiwai@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.1 (3.48.1-1.fc38) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: XZeJK2cYh6_FJFg96n3m3DSh1lseKFru X-Proofpoint-GUID: gFwwEY82wt6SRbr9Odeh7yns_RhuKhFP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-08_12,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 mlxlogscore=868 phishscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305080111 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, 2023-03-14 at 13:33 +0100, Takashi Iwai wrote: > On Tue, 14 Mar 2023 13:12:08 +0100, > Niklas Schnelle wrote: > > --- a/sound/isa/Kconfig > > +++ b/sound/isa/Kconfig > > @@ -23,6 +23,7 @@ menuconfig SND_ISA > > bool "ISA sound devices" > > depends on ISA || COMPILE_TEST > > depends on ISA_DMA_API > > + depends on HAS_IOPORT > > default y > > help > > Support for sound devices connected via the ISA bus. >=20 > With this dependency, ... >=20 > > @@ -31,6 +32,7 @@ if SND_ISA > > =20 > > config SND_ADLIB > > tristate "AdLib FM card" > > + depends on HAS_IOPORT > > select SND_OPL3_LIB > > help > > Say Y here to include support for AdLib FM cards. >=20 > ... this and lots of other similar changes become redundant, as they > already depend on CONFIG_SND_ISA. >=20 Good point and semantically it makes sense too since ISA is closely associated with I/O ports. > > --- a/sound/pcmcia/Kconfig > > +++ b/sound/pcmcia/Kconfig > > @@ -13,6 +13,7 @@ if SND_PCMCIA && PCMCIA > > config SND_VXPOCKET > > tristate "Digigram VXpocket" > > select SND_VX_LIB > > + depends on HAS_IOPORT > > help > > Say Y here to include support for Digigram VXpocket and > > VXpocket 440 soundcards. > > @@ -22,6 +23,7 @@ config SND_VXPOCKET > > =20 > > config SND_PDAUDIOCF > > tristate "Sound Core PDAudioCF" > > + depends on HAS_IOPORT > > select SND_PCM > > help > > Say Y here to include support for Sound Core PDAudioCF >=20 > I guess it's easier to make CONFIG_SND_PCMCIA depending on > CONFIG_HAS_IOPORT (like done for CONFIG_SND_ISA). >=20 In principle I think there could be a MMIO based PCMCIA sound card but it appears there is none currently supported and I doubt someone adds one so yeah that makes sense even if it isn't as clear cut as with CONFIG_SND_ISA. I've changed both vor v4. Thanks!