From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05401C433FE for ; Mon, 9 May 2022 10:17:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232750AbiEIKVk (ORCPT ); Mon, 9 May 2022 06:21:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234652AbiEIKVi (ORCPT ); Mon, 9 May 2022 06:21:38 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0E5E18F270; Mon, 9 May 2022 03:17:45 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 12B7F1F9F5; Mon, 9 May 2022 10:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652090865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=onb2w7bPIYEEL78XxSeaROmCWn+3/YkmTbagPJ1Pgf8=; b=Jqjtv2RNi2Pnvh6ZM46IOI5TpfIsI8xYg4gLrijHFmjifSiQ7khCVsp0w6tCU1HZWfTACE GWO1JDpuUblYxIJ+mHBm6lPxo2yHon13IorS8/Itz1rpOKgY5N6ItbplIIbBnzSw2lczpj R0Msg/L01Qsvw3wGcmPwZUKZM7Lge54= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652090865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=onb2w7bPIYEEL78XxSeaROmCWn+3/YkmTbagPJ1Pgf8=; b=Lk4zaFnrmOX/vKujOu7M4v9u8c2PHCQKNsPfqs2hDcYJo3j2DU+b4/61v8V6e8/YIqYUl6 y7atC+/QOOSJQBBA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id E7ECF2C141; Mon, 9 May 2022 10:07:44 +0000 (UTC) Date: Mon, 09 May 2022 12:07:44 +0200 Message-ID: From: Takashi Iwai To: Arnd Bergmann Cc: Niklas Schnelle , Arnd Bergmann , Greg Kroah-Hartman , Linux Kernel Mailing List , linux-arch , linux-pci , Jaroslav Kysela , Takashi Iwai , "moderated list:SOUND" Subject: Re: [RFC v2 31/39] sound: add HAS_IOPORT dependencies In-Reply-To: References: <20220429135108.2781579-1-schnelle@linux.ibm.com> <20220429135108.2781579-57-schnelle@linux.ibm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 09 May 2022 11:20:33 +0200, Arnd Bergmann wrote: > > On Mon, May 9, 2022 at 10:53 AM Takashi Iwai wrote: > > On Fri, 29 Apr 2022 15:50:54 +0200, Niklas Schnelle wrote: > > > > > > > config SND_OPL3_LIB > > > tristate > > > + depends on HAS_IOPPORT > > > select SND_TIMER > > > select SND_HWDEP > > > select SND_SEQ_DEVICE if SND_SEQUENCER != n > > > > Both of those are the items to be reverse-selected, so cannot fulfill > > the dependency with depends-on. That is, the items that select those > > should have the dependency on HAS_IOPORT instead. > > > > That is, a change like below: > > > > > --- a/sound/isa/Kconfig > > > +++ b/sound/isa/Kconfig > > > @@ -31,7 +31,7 @@ if SND_ISA > > > > > > config SND_ADLIB > > > tristate "AdLib FM card" > > > - select SND_OPL3_LIB > > > + depends on SND_OPL3_LIB > > > > ... won't work. CONFIG_SND_OPL3_LIB is not enabled by itself but only > > to be selected. > > Right, I missed that in my review. Not sure if this was a mistake in > my original patch or if it started in a later version. > > I think for the ISA drivers, I would still add 'depends on HAS_IOPORT' > to both CONFIG_SND_ISA and CONFIG_SND_OPL3_LIB if only to > make it easier to understand, even though CONFIG_ISA requires > HAS_IOPORT already, and CONFIG_SND_OPL3_LIB cannot be > selected by itself. Yes, that makes sense. > For the PCI drivers, I think we need to add the same dependency > on anything that either selects SND_OPL3_LIB or calls inb()/outb() > directly. Agreed. thanks, Takashi