From: sashiko-bot@kernel.org
To: "Alexander Gruhlke" <gruhlke@mailbox.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: Wait for readiness after FLR even with Immediate Readiness
Date: Sat, 10 Oct 2026 16:13:30 +0000 [thread overview]
Message-ID: <sashiko-outbox-166727@kernel.org> (raw)
In-Reply-To: <20261010160529.27974-3-gruhlke@mailbox.org>
> pcie_flr() and pci_af_flr() skip pci_dev_wait() if the device advertises
> Immediate Readiness. Since commit 10baa9b4df40 ("PCI: Drop unnecessary
> retries when restoring BARs"), the subsequent config restore isn't
> retried, so it is lost if the device isn't ready after all.
>
> The Samsung 990 PRO [144d:a80c] advertises Immediate Readiness but
> returns ~0 for 1-7 ms after FLR, which breaks VFIO passthrough. Keep
> skipping the 100 ms delay, but call pci_dev_wait().
>
> Fixes: 10baa9b4df40 ("PCI: Drop unnecessary retries when restoring BARs")
> Link: https://bbs.archlinux.org/viewtopic.php?id=314833
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Alexander Gruhlke <gruhlke@mailbox.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261010160529.27974-1-gruhlke@mailbox.org?part=2
next prev parent reply other threads:[~2026-10-10 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 16:05 [PATCH 0/2] PCI: Wait after FLR for devices that don't honor Immediate Readiness Alexander Gruhlke
2026-10-10 16:05 ` [PATCH 1/2] PCI: Don't treat ~0 as ready in pci_dev_wait() with RRS SV Alexander Gruhlke
2026-10-10 16:13 ` sashiko-bot
2026-10-10 18:36 ` Lukas Wunner
2026-10-11 8:24 ` Alexander Gruhlke
2026-10-11 15:14 ` Lukas Wunner
2026-10-10 16:05 ` [PATCH 2/2] PCI: Wait for readiness after FLR even with Immediate Readiness Alexander Gruhlke
2026-10-10 16:13 ` sashiko-bot [this message]
2026-10-10 17:51 ` Lukas Wunner
2026-10-11 8:25 ` Alexander Gruhlke
2026-10-11 16:38 ` [PATCH 0/2] PCI: Wait after FLR for devices that don't honor " Alexander Gruhlke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-166727@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=gruhlke@mailbox.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox