From: sashiko-bot@kernel.org
To: phucduc.bui@gmail.com
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PCI: tegra194: Propagate REFCLK select GPIO errors
Date: Mon, 12 Oct 2026 09:53:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-167911@kernel.org> (raw)
In-Reply-To: <20261012094815.28160-2-phucduc.bui@gmail.com>
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> devm_gpiod_get_optional() returns NULL when the optional GPIO is not
> present, but may return -EPROBE_DEFER or other errors.
>
> The current code treats GPIO lookup errors as if the GPIO were not
> present.
>
> Check the return value and propagate errors from the REFCLK select GPIO
> lookup.
>
> Reviewed-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261012094815.28160-1-phucduc.bui@gmail.com?part=2
next prev parent reply other threads:[~2026-10-12 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 9:48 [PATCH v2 1/2] PCI: tegra194: Use dev_err_probe() for PERST# GPIO phucduc.bui
2026-10-12 9:48 ` [PATCH v2 2/2] PCI: tegra194: Propagate REFCLK select GPIO errors phucduc.bui
2026-10-12 9:53 ` sashiko-bot [this message]
2026-10-13 16:21 ` Thierry Reding
2026-10-12 9:54 ` [PATCH v2 1/2] PCI: tegra194: Use dev_err_probe() for PERST# GPIO sashiko-bot
2026-10-13 16:20 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-167911@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=phucduc.bui@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox