From: sashiko-bot@kernel.org
To: "Birk Skyum" <birk.skyum@pm.me>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: qcom: Power the controller down when hibernating
Date: Mon, 12 Oct 2026 13:18:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-168162@kernel.org> (raw)
In-Reply-To: <179181074907.22199.10556821368232442334@pm.me>
> qcom_pcie_suspend_noirq() leaves the controller powered when a device
> below it cannot go to D3cold, and qcom_pcie_resume_noirq() then carries
> on with the controller as it was.
>
> That is fine for suspend. The same two functions also run as
> freeze_noirq and restore_noirq for hibernation. Devices are normally
> still in D0 at freeze, so a controller with a device behind it is left
> powered and the image records it as running. That image is resumed
> after a power cycle, by a kernel that may never have brought the
> controller up.
>
> On a Lenovo Yoga Slim 7x (X1E80100) this resets the machine on every
> resume from hibernation. The Wi-Fi card is behind pcie4, whose link
> only comes up once the power sequencing drivers have been loaded from
> the root file system. The kernel that loads the image resumes before
> [ ... ]
> dw_pcie_resume_noirq(), like after any other loss of power. Suspend and
> the poweroff phase of hibernation keep the D3cold check.
>
> Suggested-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
> Signed-off-by: Birk Skyum <birk.skyum@pm.me>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/179181074907.22199.10556821368232442334@pm.me?part=1
prev parent reply other threads:[~2026-10-12 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 13:12 [PATCH v2] PCI: qcom: Power the controller down when hibernating Birk Skyum
2026-10-12 13:18 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-168162@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=birk.skyum@pm.me \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox