Re: [PATCH v3 1/8] resource: Mark free space assigned

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] resource: incomplete fix for %pR format on candidate resource
--

commit 094e97a90a5417acb103a184b0b1c36691f9e6c3
Author: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

resource: Mark free space assigned

This commit clears the IORESOURCE_UNSET flag from the free space indicator
resource (full_avail). This prevents the flag from hampering the printing
of the resource with the %pR format specifier.

> diff --git a/kernel/resource.c b/kernel/resource.c
> index e60539a55541d..17e7fccd859cb 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -731,6 +731,7 @@ static int __find_resource_space(struct resource *root, struct resource *old,
>  	resource_alignf alignf = constraint->alignf;
>  
>  	full_avail.start = root->start;
> +	full_avail.flags &= ~IORESOURCE_UNSET;

[Severity: Low]
Is this fix incomplete?

Later in __find_resource_space(), the candidate resource 'avail' inherits
flags from the unassigned resource 'new':

kernel/resource.c:__find_resource_space() {
    ...
		/* Check for overflow after ALIGN() */
		avail.start = ALIGN(full_avail.start, constraint->align);
		avail.end = full_avail.end;
		avail.flags = new->flags;
    ...
}

Because 'new->flags' still has IORESOURCE_UNSET set, 'avail' inherits it.
When 'avail' is passed to alignf callbacks (such as pcibios_align_resource
in arch/parisc/kernel/pci.c), any %pR debug prints of this candidate
resource will incorrectly format it as a size rather than revealing the
candidate address range.

Does IORESOURCE_UNSET need to be cleared for 'avail.flags' as well to
fully resolve this %pR formatting issue?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013130948.6231-1-ilpo.jarvinen@linux.intel.com?part=1