From: sashiko-bot@kernel.org
To: "Leon Romanovsky" <leon@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v11 12/19] PCI/P2PDMA: Log detailed ACS routing diagnostics
Date: Tue, 13 Oct 2026 14:40:07 +0000 [thread overview]
Message-ID: <sashiko-outbox-169926@kernel.org> (raw)
In-Reply-To: <20261013-fix-p2p-acs-v4-0-v11-12-72cf8c96e617@nvidia.com>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> When P2PDMA rejects a mapping, existing warnings identify only the final
> ACS or host-bridge result. They omit topology, live controls, divergence
> ports, cache state, and intermediate routing decisions.
>
> Emit debug-level messages for verbose calculations and cache lookups.
> Report both paths, decoded ACS controls, directional decisions, host
> fallback, and the final mapping. The messages stay silent until enabled,
> and the existing warnings are unchanged.
>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> Tested-by: Tushar Dave <tdave@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-fix-p2p-acs-v4-0-v11-0-72cf8c96e617@nvidia.com?part=12
next prev parent reply other threads:[~2026-10-13 14:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 14:25 [PATCH v11 00/19] PCI/P2PDMA: Route peer-to-peer DMA by TLP class Leon Romanovsky
2026-10-13 14:25 ` [PATCH v11 01/19] PCI/P2PDMA: Honor device-specific ACS redirection Leon Romanovsky
2026-10-13 14:44 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 02/19] PCI/P2PDMA: Document the TLP attribute assumptions Leon Romanovsky
2026-10-13 14:28 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 03/19] PCI/P2PDMA: Derive routing from directional ACS controls Leon Romanovsky
2026-10-13 14:32 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 04/19] PCI: Reject unreadable ACS controls in isolation checks Leon Romanovsky
2026-10-13 14:37 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 05/19] PCI/P2PDMA: Evaluate ACS controls at the path divergence Leon Romanovsky
2026-10-13 14:38 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 06/19] PCI/P2PDMA: Document directional ACS routing Leon Romanovsky
2026-10-13 14:28 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 07/19] PCI/P2PDMA: Collect the path's ACS controls before deciding Leon Romanovsky
2026-10-13 14:32 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 08/19] PCI/P2PDMA: Answer routing per TLP class Leon Romanovsky
2026-10-13 14:34 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 09/19] PCI/P2PDMA: Route Relaxed Ordering Completions directly Leon Romanovsky
2026-10-13 14:37 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 10/19] PCI/P2PDMA: Reject Translated Requests blocked by Translation Blocking Leon Romanovsky
2026-10-13 14:49 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 11/19] PCI/P2PDMA: Route Translated Requests under Direct Translated P2P Leon Romanovsky
2026-10-13 14:36 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 12/19] PCI/P2PDMA: Log detailed ACS routing diagnostics Leon Romanovsky
2026-10-13 14:40 ` sashiko-bot [this message]
2026-10-13 14:25 ` [PATCH v11 13/19] PCI/P2PDMA: Add KUnit tests for the ACS routing decisions Leon Romanovsky
2026-10-13 14:40 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 14/19] PCI/P2PDMA: Test the ACS P2P routing walk Leon Romanovsky
2026-10-13 14:49 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 15/19] PCI: Add KUnit coverage for ACS isolation checks Leon Romanovsky
2026-10-13 14:44 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 16/19] PCI/P2PDMA: Document TLP-class routing Leon Romanovsky
2026-10-13 14:39 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 17/19] PCI/P2PDMA: Let a client declare that it selects ATS per mapping Leon Romanovsky
2026-10-13 14:47 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 18/19] PCI/P2PDMA: Evaluate the ATS path for clients with ATS enabled Leon Romanovsky
2026-10-13 14:47 ` sashiko-bot
2026-10-13 14:25 ` [PATCH v11 19/19] PCI/P2PDMA: Test the routing of " Leon Romanovsky
2026-10-13 14:47 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-169926@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=leon@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox