From: sashiko-bot@kernel.org
To: "Daniel Almeida" <daniel.almeida@collabora.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 7/7] drm/tyr: mark read-only and write-only registers
Date: Thu, 15 Oct 2026 12:43:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-172853@kernel.org> (raw)
In-Reply-To: <20261015-io-access-modes-v1-7-93611b84b5e3@collabora.com>
> The documentation in regs.rs describes some registers as read-only or
> write-only, but nothing enforces it, and most registers do not document
> a mode at all.
>
> Declare every read-only and write-only register with the `#[ro]` and
> `#[wo]` attributes of `register!`, so that writing a read-only register,
> or reading a write-only one, does not compile. The modes follow the
> documentation in regs.rs where there is one, and otherwise the register
> permissions in Arm's kbase driver for v10 GPUs. Both halves of a 64-bit
> register get the same mode, and so do the aliases of `GPU_COMMAND`.
>
> No existing access goes against these modes, so the driver code does not
> change.
>
> Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-io-access-modes-v1-0-93611b84b5e3@collabora.com?part=7
prev parent reply other threads:[~2026-10-15 12:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 12:39 [PATCH 0/7] rust: io: add read-only and write-only views and registers Daniel Almeida
2026-10-15 12:39 ` [PATCH 1/7] rust: io: split IoCapable into IoReadable and IoWritable Daniel Almeida
2026-10-15 12:46 ` sashiko-bot
2026-10-15 12:39 ` [PATCH 2/7] rust: io: split IoCopyable into IoCopyReadable and IoCopyWritable Daniel Almeida
2026-10-15 12:44 ` sashiko-bot
2026-10-15 12:39 ` [PATCH 3/7] rust: io: add read-only and write-only views Daniel Almeida
2026-10-15 12:44 ` sashiko-bot
2026-10-15 12:39 ` [PATCH 4/7] rust: io: project primitive accessors directly Daniel Almeida
2026-10-15 12:44 ` sashiko-bot
2026-10-15 12:39 ` [PATCH 5/7] rust: io: let I/O locations carry an access mode Daniel Almeida
2026-10-15 12:50 ` sashiko-bot
2026-10-15 12:39 ` [PATCH 6/7] rust: io: register: add `#[ro]` and `#[wo]` attributes Daniel Almeida
2026-10-15 12:47 ` sashiko-bot
2026-10-15 12:39 ` [PATCH 7/7] drm/tyr: mark read-only and write-only registers Daniel Almeida
2026-10-15 12:43 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-172853@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox