From: sashiko-bot@kernel.org
To: "Diederik de Haas" <diederik@cknow-tech.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
Date: Wed, 21 Oct 2026 10:17:52 +0000 [thread overview]
Message-ID: <sashiko-outbox-180090@kernel.org> (raw)
In-Reply-To: <20261021101533.609118-1-diederik@cknow-tech.com>
> The devm_request_threaded_irq() function already automatically logs
> detailed error messages on failure since commit
> 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
> So remove the now-redundant driver-specific dev_err() calls.
>
> Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261021101533.609118-1-diederik@cknow-tech.com?part=1
next prev parent reply other threads:[~2026-10-21 10:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 10:14 [PATCH] PCI: dw-rockchip: Remove redundant dev_err() Diederik de Haas
2026-10-21 10:17 ` sashiko-bot [this message]
2026-10-21 12:35 ` Heiko Stübner
-- strict thread matches above, loose matches on Subject: below --
2024-09-18 7:44 Chen Ni
2024-09-18 8:21 ` Heiko Stuebner
2024-09-24 14:21 ` Manivannan Sadhasivam
2024-10-06 7:39 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-180090@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=diederik@cknow-tech.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox