From: sashiko-bot@kernel.org
To: "Igor Velkov" <iav@iav.lv>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] PCI: rockchip-host: Retry link training that times out
Date: Sat, 24 Oct 2026 01:07:45 +0000 [thread overview]
Message-ID: <sashiko-outbox-183483@kernel.org> (raw)
In-Reply-To: <20261024-rockchip-pcie-resume-v1-1-58e54a5cf5f1@iav.lv>
> From: Igor Velkov <iav@iav.lv>
>
> On a Kobol Helios64 the JMB585 SATA controller sometimes does not train
> the link on resume from s2idle. The 500 ms poll times out and
> resume_noirq() returns -ETIMEDOUT. On v7.3-rc7 with the mainline DT
> this happened in the 14th of 14 cycles, and the system did not resume.
>
> When training times out, bring the port up again, at most twice. Each
> attempt initializes the PHYs again and, where PERST# is wired, holds it
> low for at least 100 ms. Without an endpoint, probe now gives up after
> three attempts, in about 2.1 s instead of 0.7 s.
>
> Print the LTSSM state with the timeout message.
>
> With the patch, one such timeout showed LTSSM 0x10, and the first retry
> trained the link.
>
> Assisted-by: LLM
> Signed-off-by: Igor Velkov <iav@iav.lv>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261024-rockchip-pcie-resume-v1-0-58e54a5cf5f1@iav.lv?part=1
next prev parent reply other threads:[~2026-10-24 1:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 1:02 [PATCH RFC 0/2] PCI: rockchip-host: Retry training and hot-reset a JMB585 on RK3399 Igor Velkov via B4 Relay
2026-10-24 1:02 ` [PATCH RFC 1/2] PCI: rockchip-host: Retry link training that times out Igor Velkov via B4 Relay
2026-10-24 1:07 ` sashiko-bot [this message]
2026-10-24 1:02 ` [PATCH RFC 2/2] PCI: rockchip-host: Hot-reset the endpoint before using the link Igor Velkov via B4 Relay
2026-10-24 1:21 ` sashiko-bot
2026-10-26 9:08 ` [PATCH RFC 0/2] PCI: rockchip-host: Retry training and hot-reset a JMB585 on RK3399 Shawn Lin
2026-10-26 18:28 ` Igor Velkov
2026-10-27 0:44 ` Shawn Lin
2026-10-27 1:15 ` Igor Velkov
2026-10-28 17:31 ` Enrique Hernández Bello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-183483@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=iav@iav.lv \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox