Re: [PATCH v5 08/23] rust: device: Expose Device from_raw() publically

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] rust: device: commit message claims to expose from_raw() instead of as_raw()
- [Low] rust: device: missing #[inline] annotation on public Device::as_raw()
--

commit 4612538f4ce0b7f345e904370c4f1a9efe8adc51
Author: Alistair Francis <alistair.francis@wdc.com>

rust: device: Expose Device from_raw() publically

This commit changes the visibility of Device::as_raw() in
rust/kernel/device.rs from pub(crate) to pub so it can be called from outside
the kernel crate.

>     rust: device: Expose Device from_raw() publically
>     
>     We are going to call the from_raw() function later as part of the SPDM
>     library, so expose it publically.
>     
>     Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

[Severity: Medium]
Should the commit subject and message refer to Device::as_raw() instead of
from_raw(), and fix the typo "publically" to "publicly"?

In rust/kernel/device.rs, Device::from_raw() was already public prior to this
patch:

    pub unsafe fn from_raw<'a>(ptr: *mut bindings::device) -> &'a Self {
        // SAFETY: Guaranteed by the safety requirements of the function.
        unsafe { &*ptr.cast() }
    }

Whereas the diff below actually exposes Device::as_raw() publicly so that
callers in lib/rspdm/lib.rs and lib/rspdm/state.rs can pass the raw device
pointer to C callbacks.

> diff --git a/rust/kernel/device.rs b/rust/kernel/device.rs
> index 2291d85b6849e..a355ac9803410 100644
> --- a/rust/kernel/device.rs
> +++ b/rust/kernel/device.rs
> @@ -262,7 +262,7 @@ pub unsafe fn drvdata_borrow<T>(&self) -> Pin<&T> {
>  
>  impl<Ctx: DeviceContext> Device<Ctx> {
>      /// Obtain the raw `struct device *`.
> -    pub(crate) fn as_raw(&self) -> *mut bindings::device {
> +    pub fn as_raw(&self) -> *mut bindings::device {

[Severity: Low]
This isn't a bug, but since Device::as_raw() in rust/kernel/device.rs is a
small one-line accessor in the kernel crate now exposed across crate
boundaries, should it be annotated with #[inline]?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027052536.1722081-1-alistair.francis@wdc.com?part=8