Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hans Zhang" <18255117159@163.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: tegra194: Clear event counter masks before programming
Date: Mon, 02 Nov 2026 06:41:40 +0000	[thread overview]
Message-ID: <sashiko-outbox-192963@kernel.org> (raw)
In-Reply-To: <20261102063835.3831940-1-18255117159@163.com>

> When programming the RAS-DES event counter control register, the code only
> cleared the event-selection field before OR-ing in the new group, event,
> and enable values. This leaves stale bits in the group-select and enable
> fields from prior writes.
> 
> Clear all three field masks before programming the register so that stale
> bits are not preserved across updates.
> 
> No functional change intended beyond ensuring the register is rewritten
> without carrying over previous field values.
> 
> Signed-off-by: Hans Zhang <18255117159@163.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102063835.3831940-1-18255117159@163.com?part=1


  reply	other threads:[~2026-11-02  6:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  6:38 [PATCH] PCI: dwc: tegra194: Clear event counter masks before programming Hans Zhang
2026-11-02  6:41 ` sashiko-bot [this message]
2026-11-07 21:50 ` Manivannan Sadhasivam
2026-11-07 23:15   ` Hans Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-192963@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=18255117159@163.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox