Re: [PATCH 2/2] PCI: switchtec: Add Gen6 secure switches to NTB DMA alias quirk

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] PCI: switchtec: missing Gen6 device IDs in quirk_switchtec_ntb_dma_alias()
--

commit 17094c1753a87a229df82238fb75b9bb1b5728fe
Author: Logan Gunthorpe <logang@deltatee.com>

PCI: switchtec: Add Gen6 secure switches to NTB DMA alias quirk

This commit adds four Gen6 PFXs and PSXs secure switch device IDs to the
quirk_switchtec_ntb_dma_alias() PCI fixup table so NTB DMA transactions
receive the proper requester ID alias under an IOMMU.

> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 7f1f47ea2ee41..691eff466d9ce 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -6250,6 +6250,10 @@ SWITCHTEC_QUIRK(0x5568);  /* PAXA 68XG5 */
>  SWITCHTEC_QUIRK(0x5552);  /* PAXA 52XG5 */
>  SWITCHTEC_QUIRK(0x5536);  /* PAXA 36XG5 */
>  SWITCHTEC_QUIRK(0x5528);  /* PAXA 28XG5 */
> +SWITCHTEC_QUIRK(0x6064);  /* PFXs 64XG6 */
> +SWITCHTEC_QUIRK(0x6048);  /* PFXs 48XG6 */
> +SWITCHTEC_QUIRK(0x6164);  /* PSXs 64XG6 */
> +SWITCHTEC_QUIRK(0x6148);  /* PSXs 48XG6 */

[Severity: Medium]
Should the remaining 12 Gen6 Switchtec device IDs from switchtec_pci_tbl in
drivers/pci/switch/switchtec.c also be added to SWITCHTEC_QUIRK() here?

Commit 5e6c21c56998 ("PCI: switchtec: Add Gen6 Device IDs") added all 16 Gen6
Switchtec device IDs to switchtec_pci_tbl via SWITCHTEC_PCI_DEVICE(...,
SWITCHTEC_GEN6), which binds both PCI_CLASS_MEMORY_OTHER and the NTB endpoint
class PCI_CLASS_BRIDGE_OTHER:

drivers/pci/switch/switchtec.c:switchtec_pci_tbl[] = {
    ...
	SWITCHTEC_PCI_DEVICE(0x6048, SWITCHTEC_GEN6),  /* PFXs 48XG6 */
	SWITCHTEC_PCI_DEVICE(0x6064, SWITCHTEC_GEN6),  /* PFXs 64XG6 */
	SWITCHTEC_PCI_DEVICE(0x6044, SWITCHTEC_GEN6),  /* PFXs 144XG6 */
	SWITCHTEC_PCI_DEVICE(0x6060, SWITCHTEC_GEN6),  /* PFXs 160XG6 */
	SWITCHTEC_PCI_DEVICE(0x6148, SWITCHTEC_GEN6),  /* PSXs 48XG6 */
	SWITCHTEC_PCI_DEVICE(0x6164, SWITCHTEC_GEN6),  /* PSXs 64XG6 */
	SWITCHTEC_PCI_DEVICE(0x6144, SWITCHTEC_GEN6),  /* PSXs 144XG6 */
	SWITCHTEC_PCI_DEVICE(0x6160, SWITCHTEC_GEN6),  /* PSXs 160XG6 */
	SWITCHTEC_PCI_DEVICE(0x6248, SWITCHTEC_GEN6),  /* PFX 48XG6 */
	SWITCHTEC_PCI_DEVICE(0x6264, SWITCHTEC_GEN6),  /* PFX 64XG6 */
	SWITCHTEC_PCI_DEVICE(0x6244, SWITCHTEC_GEN6),  /* PFX 144XG6 */
	SWITCHTEC_PCI_DEVICE(0x6260, SWITCHTEC_GEN6),  /* PFX 160XG6 */
	SWITCHTEC_PCI_DEVICE(0x6348, SWITCHTEC_GEN6),  /* PSX 48XG6 */
	SWITCHTEC_PCI_DEVICE(0x6364, SWITCHTEC_GEN6),  /* PSX 64XG6 */
	SWITCHTEC_PCI_DEVICE(0x6344, SWITCHTEC_GEN6),  /* PSX 144XG6 */
	SWITCHTEC_PCI_DEVICE(0x6360, SWITCHTEC_GEN6),  /* PSX 160XG6 */
    ...
};

Every Gen3, Gen4, Gen5, and PCI100x device ID in switchtec_pci_tbl has a
matching SWITCHTEC_QUIRK() or SWITCHTEC_PCI100X_QUIRK() entry in
drivers/pci/quirks.c for PCI_CLASS_BRIDGE_OTHER.

Without entries for the other four Gen6 PFXs/PSXs secure switch IDs (0x6044,
0x6060, 0x6144, 0x6160) and the eight non-secure Gen6 PFX/PSX switch IDs
(0x6248, 0x6264, 0x6244, 0x6260, 0x6348, 0x6364, 0x6344, 0x6360), will
quirk_switchtec_ntb_dma_alias() fail to run during PCI enumeration for those
models, leaving their NTB proxy requester IDs unaliased under an IOMMU?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103170033.471034-1-logang@deltatee.com?part=2