Re: [PATCH] PCI: octep: size the interrupt name buffer for the full format range

[sashiko-bot@kernel.org]

> octep_hp_request_irq() formats the interrupt name with "octep_hp_%d"
> into a 16-byte array.  The prefix is 9 bytes and a full-range %d
> argument can add up to 11 more, so the worst case needs 21 bytes
> including the terminator and 0-day reports:
> 
>   drivers/pci/hotplug/octep_hp.c:312:53: warning: '%d' directive output
>   may be truncated writing between 1 and 10 bytes into a region of size 7
>   [-Wformat-truncation=]
>   note: 'snprintf' output between 11 and 20 bytes into a destination of
>   size 16
> 
> The values passed today are OCTEP_HP_INTR_ENA and OCTEP_HP_INTR_DIS, so
> no truncation actually happens, but the buffer carries no margin over
> the format's worst case.  Give it the room so the warning stops coming
> back from builds that cannot narrow the argument.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507261457.SXXHOjUk-lkp@intel.com/
> Signed-off-by: xujiahao <xujiahao@cmss.chinamobile.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105092705.3099201-1-xujiahao@cmss.chinamobile.com?part=1