From: sashiko-bot@kernel.org
To: "Herve Codina" <herve.codina@bootlin.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v14 09/10] PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge node
Date: Thu, 05 Nov 2026 16:23:28 +0000 [thread overview]
Message-ID: <sashiko-outbox-199476@kernel.org> (raw)
In-Reply-To: <20261103155540.365294-10-herve.codina@bootlin.com>
> During the instantiation of devices described by a device-tree overlay
> applied on a PCI device, devlink displays the following kind of debug
> messages instead of creating the expected links:
> 'Not linking xxxx - might never become dev'
>
> Without those expected links, the device removal order cannot be
> correct.
>
> Those debug traces are printed by fw_devlink_create_devlink(). In our
> use case, they are all printed because the supplier of the link has at
> least one of its ancestor with its fwnode flag FWNODE_FLAG_INITIALIZED
> set.
>
> The culprit ancestor is the PCI root bridge.
>
> [ ... ]
> are correctly created.
>
> Fixes: 1f340724419e ("PCI: of: Create device tree PCI host bridge node")
> Cc: stable@vger.kernel.org
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103155540.365294-1-herve.codina@bootlin.com?part=9
next prev parent reply other threads:[~2026-11-05 16:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 15:55 [PATCH v14 00/10] lan966x pci device: Add support for SFPs, PCI part Herve Codina
2026-11-03 15:55 ` [PATCH v14 01/10] driver core: fw_devlink: Introduce fw_devlink_set_device() Herve Codina
2026-11-05 15:44 ` sashiko-bot
2026-11-03 15:55 ` [PATCH v14 02/10] drivers: core: Use fw_devlink_set_device() Herve Codina
2026-11-05 15:46 ` sashiko-bot
2026-11-03 15:55 ` [PATCH v14 03/10] pinctrl: cs42l43: " Herve Codina
2026-11-05 15:55 ` sashiko-bot
2026-11-03 15:55 ` [PATCH v14 04/10] cxl/test: Use device_set_node() Herve Codina
2026-11-05 15:57 ` sashiko-bot
2026-11-03 15:55 ` [PATCH v14 05/10] cxl/test: Use fw_devlink_set_device() Herve Codina
2026-11-05 15:58 ` sashiko-bot
2026-11-03 15:55 ` [PATCH v14 06/10] PCI: of: " Herve Codina
2026-11-05 16:02 ` sashiko-bot
2026-11-03 15:55 ` [PATCH v14 07/10] PCI: of: Clear fwnode->dev during root bridge node removal and error path Herve Codina
2026-11-05 16:08 ` sashiko-bot
2026-11-03 15:55 ` [PATCH v14 08/10] PCI: of: Set fwnode device of newly created PCI device nodes Herve Codina
2026-11-05 16:18 ` sashiko-bot
2026-11-03 15:55 ` [PATCH v14 09/10] PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge node Herve Codina
2026-11-05 16:23 ` sashiko-bot [this message]
2026-11-03 15:55 ` [PATCH v14 10/10] PCI: of: Avoid np->data usage for the node changeset Herve Codina
2026-11-05 16:27 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-199476@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=herve.codina@bootlin.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox