From: sashiko-bot@kernel.org
To: "Ziyou Wang (Lenovo)" <ziyou.dev@foxmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI/DPC: Increase recovery timeout to 60 seconds
Date: Fri, 06 Nov 2026 09:05:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-201098@kernel.org> (raw)
In-Reply-To: <tencent_BB887B4DB8D2131AF5026893E0FE567D6D05@qq.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI: orphaned PCIE_RESET_READY_POLL_MS comment left in
drivers/pci/pci.c
--
commit b65aa35af6ea60927f9e516408b33a731c59921c
Author: Ziyou Wang (Lenovo) <ziyou.dev@foxmail.com>
PCI/DPC: Increase recovery timeout to 60 seconds
This commit moves PCIE_RESET_READY_POLL_MS from drivers/pci/pci.c to
drivers/pci/pci.h and uses it as the DPC recovery timeout in
pci_dpc_recovered().
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index d6590805faeb2..dae2e74e64777 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -82,7 +82,6 @@ struct pci_pme_device {
> * limit, but 60 sec ought to be enough for any device to become
> * responsive.
> */
> -#define PCIE_RESET_READY_POLL_MS 60000 /* msec */
>
> static void pci_dev_d3_sleep(struct pci_dev *dev)
> {
[Severity: Low]
This isn't a bug, but moving PCIE_RESET_READY_POLL_MS to drivers/pci/pci.h
leaves its original comment block orphaned above pci_dev_d3_sleep(). Should
the comment be removed here as well since it was copied to drivers/pci/pci.h?
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_BB887B4DB8D2131AF5026893E0FE567D6D05@qq.com?part=1
next prev parent reply other threads:[~2026-11-06 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261106082612.1840817-1-ziyou.dev@foxmail.com>
2026-11-06 8:56 ` [PATCH v2] PCI/DPC: Increase recovery timeout to 60 seconds Ziyou Wang (Lenovo)
2026-11-06 9:05 ` sashiko-bot [this message]
2026-11-06 15:21 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-201098@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=ziyou.dev@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox