Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/3] PCI: Honor window granularity during resource distribution
Date: Mon, 09 Nov 2026 14:58:03 +0000	[thread overview]
Message-ID: <sashiko-outbox-205139@kernel.org> (raw)
In-Reply-To: <20261109144553.2516-4-ilpo.jarvinen@linux.intel.com>

> When a bus below a hotplug bridge has BARs smaller than the window
> granularity, removing them leaves available[i].start unaligned.
> pci_bus_distribute_available_resources() then aligns the start up for the
> downstream bridge but keeps the end, so the size passed to
> adjust_bridge_window() has a sub-granularity tail. The bridge window ends
> up not being a multiple of the window granularity.
> 
> Align the size down to the window granularity after aligning the start.
> 
> Consider a hotplug Root Port (bus 01) with a Switch Upstream Port (bus 02)
> below it that has an e1000 and an ivshmem with a 64k pref BAR as its other
> Functions. When the switch is hot-added (emulated with a remove and
> rescan), /proc/iomem before and after this change is:
> 
>    faa00000-fe9fffff : PCI Bus 0000:01
> [ ... ]
> of 01:00.1 and 01:00.2.
> 
> Fixes: 9db0b9b6a142 ("PCI: Take other bus devices into account when distributing resources")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109144553.2516-1-ilpo.jarvinen@linux.intel.com?part=3


  reply	other threads:[~2026-11-09 14:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 14:45 [PATCH 0/3] PCI: Fix hotplug memory distribute Ilpo Järvinen
2026-11-09 14:45 ` [PATCH 1/3] PCI: Fix NULL dereference when shrinking window without optional size Ilpo Järvinen
2026-11-09 14:52   ` sashiko-bot
2026-11-09 14:45 ` [PATCH 2/3] PCI: Fix start of available space for the next bridge during distribution Ilpo Järvinen
2026-11-09 14:51   ` sashiko-bot
2026-11-09 14:45 ` [PATCH 3/3] PCI: Honor window granularity during resource distribution Ilpo Järvinen
2026-11-09 14:58   ` sashiko-bot [this message]
2026-11-09 22:59 ` [PATCH 0/3] PCI: Fix hotplug memory distribute Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-205139@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox