From: sashiko-bot@kernel.org
To: zhaofeng2 <zhaofeng2@cmss.chinamobile.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/3] PCI: keystone: Fix device node leak in ks_pcie_init_id()
Date: Tue, 10 Nov 2026 10:19:26 +0000 [thread overview]
Message-ID: <sashiko-outbox-206857@kernel.org> (raw)
In-Reply-To: <20261110100955.1046-2-zhaofeng2@cmss.chinamobile.com>
> From: Zhao Feng <zhaofeng2@cmss.chinamobile.com>
>
> ks_pcie_init_id() resolves the "ti,syscon-pcie-id" phandle with
> of_parse_phandle_with_fixed_args() to obtain the device-id register
> offset, which takes a reference on the syscon device node, but the
> reference is never dropped after the offset has been read from
> args.args[0], so the syscon node is leaked on every probe.
>
> Drop the reference with of_node_put() once the offset argument has
> been consumed.
>
> Fixes: 7dcf07ac8867 ("PCI: keystone: Use phandle argument from "ti,syscon-pcie-id"/"ti,syscon-pcie-mode"")
> Signed-off-by: Zhao Feng <zhaofeng2@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110100955.1046-1-zhaofeng2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-10 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 10:09 [PATCH 0/3] PCI: keystone: Fix device node leaks in syscon phandle parsing zhaofeng2
2026-11-10 10:09 ` [PATCH 1/3] PCI: keystone: Fix device node leak in ks_pcie_init_id() zhaofeng2
2026-11-10 10:19 ` sashiko-bot [this message]
2026-11-10 10:09 ` [PATCH 2/3] PCI: keystone: Fix device node leak in ks_pcie_set_mode() zhaofeng2
2026-11-10 10:18 ` sashiko-bot
2026-11-10 10:09 ` [PATCH 3/3] PCI: keystone: Fix device node leak in ks_pcie_am654_set_mode() zhaofeng2
2026-11-10 10:14 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-206857@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhaofeng2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox