Re: [PATCH v3 2/2] PCI/PM: Avoid D3cold for HP Spectre x360 Convertible 15-ch0xx PCIe Ports

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] PCI/PM: undocumented HP ZBook 15 G4 entry added to
  bridge_d3_blacklist
--

commit 3a39b259ab0d752d9836cb09fe7994c45196ce7c
Author: Mario Limonciello <superm1@kernel.org>

PCI/PM: Avoid D3cold for HP Spectre x360 Convertible 15-ch0xx PCIe Ports

This commit adds DMI quirks to bridge_d3_blacklist to disable D3 power
management for PCIe ports on affected HP laptops.

> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 17ec7f065682d..bced3a0e3e853 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -3039,6 +3039,24 @@ static const struct dmi_system_id bridge_d3_blacklist[] = {
>  			DMI_MATCH(DMI_BOARD_NAME, "314D"),
>  		},
>  	},
> +	{
> +		/*
> +		 * Changing power state of root port dGPU is connected fails
> +		 * https://gitlab.freedesktop.org/drm/amd/-/work_items/3389
> +		 */
> +		.ident = "HP Spectre x360 Convertible 15-ch0xx",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
> +			DMI_MATCH(DMI_BOARD_NAME, "83BB"),
> +		},
> +	},
> +	{
> +		.ident = "HP ZBook 15 G4",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
> +			DMI_MATCH(DMI_BOARD_NAME, "8275"),
> +		},
> +	},

[Severity: Medium]
Was the "HP ZBook 15 G4" entry included in bridge_d3_blacklist[] by
accident?  The commit message only describes the HP Spectre x360
Convertible 15-ch0xx, and unlike the other entries in this table there
is no comment explaining why PCIe port D3 must be disabled on board
8275.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-superm1-kbz-222179-v3-0-f20b5ac06b6d@kernel.org?part=2