Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Matt Thompson" <matt@boondocker.io>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH RFC v2 1/3] PCI: rockchip-host: Skip downstream config access while link is down
Date: Sat, 14 Nov 2026 01:03:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-213976@kernel.org> (raw)
In-Reply-To: <20261113-rfc-b4-v2-1-d6b14f95c1d6@boondocker.io>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI: rockchip-host: missing Fixes trailer for link-down config
  access fix
--

commit 776ef94e954858f6a44d96ce2b3db1d4c94ca081
Author: Matt Thompson <matt@boondocker.io>

> PCI: rockchip-host: Skip downstream config access while link is down
>
> On a RockPro64, a PCI bus rescan with the downstream FPGA unavailable
> faulted in rockchip_pcie_rd_conf() during a vendor ID read. The rescan
> task exited with interrupts disabled and the watchdog reported a lockup.
>
> Check the controller's link-up and link-training status before issuing
> downstream config requests. Return PCIBIOS_DEVICE_NOT_FOUND while the
> link is unavailable. Root port config access still uses the local
> controller registers.
>
> This check cannot prevent the link from dropping during the transaction.
>
> Signed-off-by: Matt Thompson <matt@boondocker.io>

[Severity: Low]
This fixes a kernel fault when rockchip_pcie_rd_other_conf() or
rockchip_pcie_wr_other_conf() issues a downstream config access while the
link is down.  Should this include:

  Fixes: e77f847df54c ("PCI: rockchip: Add Rockchip PCIe controller support")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-rfc-b4-v2-0-d6b14f95c1d6@boondocker.io?part=1

  reply	other threads:[~2026-11-14  1:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14  0:52 [PATCH RFC v2 0/3] PCI: rockchip-host: Handle unavailable downstream config space Matt Thompson via B4 Relay
2026-11-14  0:52 ` [PATCH RFC v2 1/3] PCI: rockchip-host: Skip downstream config access while link is down Matt Thompson via B4 Relay
2026-11-14  1:03   ` sashiko-bot [this message]
2026-11-14  0:52 ` [PATCH RFC v2 2/3] arm64: Allow synchronous abort fixups for guarded MMIO reads Matt Thompson via B4 Relay
2026-11-14  1:02   ` sashiko-bot
2026-11-14  0:52 ` [PATCH RFC v2 3/3] PCI: rockchip-host: Recover downstream configuration access Matt Thompson via B4 Relay
2026-11-14  1:01   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-213976@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matt@boondocker.io \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox