From: sashiko-bot@kernel.org
To: "Atharva Tiwari" <atharvatiwarilinuxdev@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: Add quirk to mask ACSViol on XHCI on iMac20,1 And iMac20,2
Date: Mon, 16 Nov 2026 01:24:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-215990@kernel.org> (raw)
In-Reply-To: <20261116010835.1191-1-atharvatiwarilinuxdev@gmail.com>
> On iMac20,1 and iMac20,2 the Thunderbolt xHCI (8086:15ec) triggers an ACS
> Violation on its upstream port whenever it is runtime-resumed from D3hot,
> e.g. on suspend and shutdown:
>
> [ 141.535310] pcieport 0000:00:1c.4: AER: Uncorrectable (Non-Fatal) Error message received from 0000:08:02.0
> [ 141.535325] pcieport 0000:08:02.0: PCIe Bus Error: severity=Uncorrectable (Non-Fatal)
> [ 141.535325] pcieport 0000:08:02.0: device [8086:15ea] error status/mask=00200000/00000000
> [ 141.535327] pcieport 0000:08:02.0: [21] ACSViol | Receiver | Transaction Layer (First)
> [ 141.535328] pcieport 0000:08:02.0: AER: TLP Header: 0x34000000 0x00000010 0x00000000 0x00000000
> [ 141.551637] xhci_hcd 0000:0a:00.0: AER: can't recover (no error_detected callback)
> [ 141.551655] pcieport 0000:08:02.0: AER: device recovery failed
>
> The violation is raised inside the 10 ms D3hot->D0 recovery window: the
> port's AER status is still clean right after the PM_CTRL write
> and set once the delay has elapsed,
> before any config space has been restored.
> The kernel cannot run anything in that window.
> The ACPI _PS0 and _PS3 methods were also checked and have no effect on it.
>
> This is most likely a hardware defect: the port correctly drops the
> message, and the same controller on MacBookPro16,1 is not affected. The
> error is unrecoverable noise, so mask ACSViol on the upstream port on these
> models. ACS stays enabled.
>
> Signed-off-by: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116010835.1191-1-atharvatiwarilinuxdev@gmail.com?part=1
prev parent reply other threads:[~2026-11-16 1:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 1:08 [PATCH] PCI: Add quirk to mask ACSViol on XHCI on iMac20,1 And iMac20,2 Atharva Tiwari
2026-11-16 1:24 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215990@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=atharvatiwarilinuxdev@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox