Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Igor Velkov" <iav@iav.lv>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: rockchip-host: Retry link bring-up on repeated Recovery
Date: Mon, 16 Nov 2026 07:11:21 +0000	[thread overview]
Message-ID: <sashiko-outbox-216392@kernel.org> (raw)
In-Reply-To: <20261116-rockchip-pcie-resume-v2-1-a633e279be97@iav.lv>

> From: Igor Velkov <iav@iav.lv>
> 
> On Kobol Helios64 (RK3399 with a JMB585 at x2) about 3% of link
> bring-ups go bad. The LTSSM reaches L0 and then re-enters Recovery about
> every 200 us; the RC sees DLLPs about 300 times as often as on a good
> link, with no DLLP or CRC errors. The first config read behind the port
> gets no completion and aborts the CPU, or link training times out. The
> state survives Recovery, and a new bring-up of the port clears it.
> 
> After the link comes up, poll the LTSSM for 5 ms and treat more than two
> entries into Recovery as a bad bring-up. The RC runs at 2.5 GT/s only,
> so no speed change goes through Recovery, and good bring-ups on the
> boards we tested showed no Recovery entries after L0. Bring the port up
> again, up to five tries in all with 500 ms between them, for this and
> for a training timeout. An empty slot stays in Detect, so a timeout
> there fails on the first try. If no try gives a usable link, probe and
> resume fail as they do on a training timeout today.
> 
> Every link bring-up takes 5 ms longer. A link that stays bad delays the
> failure by 3 to 5 s.
> 
> Signed-off-by: Igor Velkov <iav@iav.lv>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-rockchip-pcie-resume-v2-1-a633e279be97@iav.lv?part=1


      reply	other threads:[~2026-11-16  7:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:05 [PATCH v2] PCI: rockchip-host: Retry link bring-up on repeated Recovery Igor Velkov via B4 Relay
2026-11-16  7:11 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216392@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=iav@iav.lv \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox