Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Linux PCI" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v3] ACPI: PM: Avoid initializing power management for absent devices
Date: Tue, 17 Nov 2026 19:24:07 +0000	[thread overview]
Message-ID: <sashiko-outbox-219466@kernel.org> (raw)
In-Reply-To: <13013440.O9o76ZdvQC@rafael.j.wysocki>

> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> 
> Commit 2f4ddf2bd1ba ("ACPI: scan: Stop calling acpi_bus_init_power()
> early") removed a device presence check from acpi_bus_init_power() which
> in some cases causes power management to be initialized for an ACPI
> device object and never used going forward.  That in turn may prevent
> power management from working as expected for other devices.
> 
> Namely, if a given ACPI device object is not enabled according to its
> _STA, find_child_checks() will return an error for it which will prevent
> it from being used as an ACPI companion for a PCI device.  Thus if
> acpi_device_init_power() initializes power management for it and its
> initial power state turns out to be different from D3cold, it may stay
> in that power state forever.  If it has power resources and they are
> "on" during the initialization, they may be reference-counted and never
> turned off.  If they are shared with other devices, they will prevent
> power from going down after attempting to put the other devices into
> low-power states.
> 
> To prevent that from happening, restore the device presence check in
> acpi_bus_init_power(), but also adjust find_child_checks() to return
> an error for absent devices (instead of doing that for disabled devices)
> in accordance with acpi_bus_init_power() and the existing check in
> acpi_bus_attach().
> 
> Fixes: 2f4ddf2bd1ba ("ACPI: scan: Stop calling acpi_bus_init_power() early")
> Reported-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>
> Tested-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/13013440.O9o76ZdvQC@rafael.j.wysocki?part=1


      reply	other threads:[~2026-11-17 19:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 19:09 [PATCH v3] ACPI: PM: Avoid initializing power management for absent devices Rafael J. Wysocki
2026-11-17 19:24 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219466@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox