Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vishal Satle" <vishalsatleit24@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: mobiveil: Drop unnecessary msi-parent check in ls_g4_pcie_probe()
Date: Wed, 18 Nov 2026 09:45:11 +0000	[thread overview]
Message-ID: <sashiko-outbox-220620@kernel.org> (raw)
In-Reply-To: <20261118093731.43980-1-vishalsatleit24@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI: mobiveil: missing Fixes trailer for device_node leak in
  ls_g4_pcie_probe()
--

commit f42a1868186c1406c426daa13adc92dc71419de8
Author: Vishal Satle <vishalsatleit24@gmail.com>

> PCI: mobiveil: Drop unnecessary msi-parent check in ls_g4_pcie_probe()
>
> ls_g4_pcie_probe() calls of_parse_phandle(np, "msi-parent", 0) solely as
> a boolean existence check without releasing the returned device_node via
> of_node_put(), leaking a reference count on probe.
>
> Instead of keeping the check with of_node_put(), drop the check
> altogether. The driver does not use the phandle directly (the irqchip
> layer handles it), other PCI controller drivers do not enforce this
> check, and without "msi-parent" INTx still works even though MSIs will
> not, so probing does not need to fail.
>
> Also remove the now-unused local variable np.
>
> Suggested-by: Manivannan Sadhasivam <mani@kernel.org>
> Cc: stable@vger.kernel.org
> Signed-off-by: Vishal Satle <vishalsatleit24@gmail.com>

[Severity: Low]
Since this fixes the device_node reference count leak in
ls_g4_pcie_probe(), should this include:

  Fixes: d29ad70a813b ("PCI: mobiveil: Add PCIe Gen4 RC driver for Layerscape SoCs")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118093731.43980-1-vishalsatleit24@gmail.com?part=1

      reply	other threads:[~2026-11-18  9:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27  9:44 [PATCH] PCI: mobiveil: Fix device_node leak in ls_g4_pcie_probe() Vishal Satle
2026-10-27  9:49 ` sashiko-bot
2026-11-05 14:14 ` Manivannan Sadhasivam
2026-11-18  9:37 ` [PATCH v2] PCI: mobiveil: Drop unnecessary msi-parent check " Vishal Satle
2026-11-18  9:45   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220620@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vishalsatleit24@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox