Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vidya Sagar" <vidyas@nvidia.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH V1 1/4] PCI/CXL: Don't offer 'cxl_bus' reset where a bus reset can't work
Date: Thu, 19 Nov 2026 10:20:00 +0000	[thread overview]
Message-ID: <sashiko-outbox-222943@kernel.org> (raw)
In-Reply-To: <20261119100628.1948990-2-vidyas@nvidia.com>

> cxl_reset_bus_function() reports the "cxl_bus" reset method as supported
> whenever the device's upstream bridge has a CXL Port DVSEC.  The reset
> itself goes through pci_reset_bus_function(), which can only reset the
> device through a hotplug slot or a Secondary Bus Reset of the parent
> bridge.  It returns -ENOTTY when neither is possible, e.g., when other
> functions share the device's bus, when the device is a bridge, or when it
> has PCI_DEV_FLAGS_NO_BUS_RESET.
> 
> "cxl_bus" is then listed in "reset_method" but always fails.  For example,
> on function 1 of a 4-function ConnectX-8 below a CXL-capable Root Port
> without a hotplug slot, "bus" is correctly not offered, but "cxl_bus" is:
> 
>   # cat /sys/bus/pci/devices/0001:01:00.1/reset_method
>   flr cxl_bus
>   # echo cxl_bus > /sys/bus/pci/devices/0001:01:00.1/reset_method
>   # echo 1 > /sys/bus/pci/devices/0001:01:00.1/reset
>   bash: echo: write error: Inappropriate ioctl for device
> 
> Each attempt still temporarily sets "Unmask SBR" in the Root Port and runs
> the IOMMU reset prepare/done hooks, although no reset happens.
> 
> Move the slot and parent bus reset from pci_reset_bus_function() into a
> new __pci_reset_bus_function() and use it for the "cxl_bus" probe.  The
> probe now makes the same slot and parent-bus checks as the "bus" probe.
> "cxl_bus" is then offered under the same conditions as "bus", except for
> the CXL SBR mask that "cxl_bus" exists to clear.
> 
> Fixes: 53c49b6e6dd2 ("PCI/CXL: Add 'cxl_bus' reset method for devices below CXL Ports")
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119100628.1948990-2-vidyas@nvidia.com?part=1


  reply	other threads:[~2026-11-19 10:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 10:06 [PATCH V1 0/4] PCI: Don't list reset methods that can't reset the device Vidya Sagar
2026-11-19 10:06 ` [PATCH V1 1/4] PCI/CXL: Don't offer 'cxl_bus' reset where a bus reset can't work Vidya Sagar
2026-11-19 10:20   ` sashiko-bot [this message]
2026-11-19 10:06 ` [PATCH V1 2/4] PCI: Don't run IOMMU reset hooks when only probing reset methods Vidya Sagar
2026-11-19 10:14   ` sashiko-bot
2026-11-19 10:06 ` [PATCH V1 3/4] PCI/sysfs: Take the device lock when setting " Vidya Sagar
2026-11-19 10:20   ` sashiko-bot
2026-11-19 10:06 ` [PATCH V1 4/4] PCI: Re-check function 0 reset methods after scanning its slot Vidya Sagar
2026-11-19 10:32   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222943@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox