Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Abhishek Kumar" <abhishek.kumar15@oss.qualcomm.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/pwrctrl: tc9563: Enable 8 GT/s equalization fine-tuning
Date: Thu, 19 Nov 2026 11:32:13 +0000	[thread overview]
Message-ID: <sashiko-outbox-223042@kernel.org> (raw)
In-Reply-To: <20261119-tc9563_fine_tune-v1-1-b83c74bf1e94@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI/pwrctrl: tc9563: missing Fixes trailer for 8 GT/s EQ
  fine-tuning fix
--

commit ae3834e64204d960937f7bf637e84695589097d7
Author: Abhishek Kumar <abhishek.kumar15@oss.qualcomm.com>

> PCI/pwrctrl: tc9563: Enable 8 GT/s equalization fine-tuning
>
> On some boots, links on the PCIe switch report a continuous flood of
> correctable AER errors (RxErr, BadTLP and Replay Timer Timeout) at
> 8 GT/s. This happens because the 8 GT/s equalization fine-tuning
> setting is never programmed: max_num_of_fine_tuning_iterations_at_8gt
> in K_EQUTUNING_033_028 resets to 0, so equalization only selects a
> preset and never fine-tunes the transmitter coefficients for the
> channel, leaving the link with marginal signal quality.
>
> Fix this by programming one fine-tuning iteration on the upstream port
> and downstream ports 1 and 2 at power-on, so that 8 GT/s equalization
> adapts the transmitter coefficients to the channel. With this setting
> the links no longer report any AER errors.
>
> Signed-off-by: Abhishek Kumar <abhishek.kumar15@oss.qualcomm.com>

[Severity: Low]
This fixes a missing initialization step from when the TC9563 power control
driver was introduced.  Should this include:

  Fixes: 4c9c7be47310 ("PCI: pwrctrl: Add power control driver for TC9563")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-tc9563_fine_tune-v1-1-b83c74bf1e94@oss.qualcomm.com?part=1

      reply	other threads:[~2026-11-19 11:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 11:27 [PATCH] PCI/pwrctrl: tc9563: Enable 8 GT/s equalization fine-tuning Abhishek Kumar
2026-11-19 11:32 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223042@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=abhishek.kumar15@oss.qualcomm.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox