From: sashiko-bot@kernel.org
To: "Danny Gonzalez" <digonzal@google.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 1/2] iommu: Track whether pci_dev_reset_iommu_done() needs to restore state
Date: Fri, 20 Nov 2026 00:33:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-224268@kernel.org> (raw)
In-Reply-To: <20261120002311.394649-2-digonzal@google.com>
> Currently, pci_dev_reset_iommu_done() relies on the assumption that
> pci_ats_supported() and dev_has_iommu() always return the same values
> they returned in pci_dev_reset_iommu_prepare(). While that may be true
> today, relying on both calls evaluating identically is fragile: if they
> ever return different values, gdev->reset_depth, group->recovery_cnt,
> group->domain, and gdev->blocked will get out of sync.
>
> Have pci_dev_reset_iommu_prepare() track whether
> pci_dev_reset_iommu_done() needs to restore IOMMU state via a @restore
> output flag, and pass @restore to pci_dev_reset_iommu_done() instead of
> re-evaluating pci_ats_supported() and dev_has_iommu().
>
> Signed-off-by: Danny Gonzalez <digonzal@google.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120002311.394649-1-digonzal@google.com?part=1
next prev parent reply other threads:[~2026-11-20 0:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 0:23 [PATCH v3 0/2] PCI/ATS: Disable ATS when ACS TB is set upstream Danny Gonzalez
2026-11-20 0:23 ` [PATCH v3 1/2] iommu: Track whether pci_dev_reset_iommu_done() needs to restore state Danny Gonzalez
2026-11-20 0:33 ` sashiko-bot [this message]
2026-11-20 0:23 ` [PATCH v3 2/2] PCI/ATS: Disable ATS when ACS TB is set upstream Danny Gonzalez
2026-11-20 0:34 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224268@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=digonzal@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox