From: sashiko-bot@kernel.org
To: "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>
Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-phy@lists.infradead.org, robh@kernel.org,
conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
olteanv@gmail.com
Subject: Re: [PATCH 10/11] bus: mhi: host: pci_generic: Add support for Qualcomm Nord
Date: Sun, 22 Nov 2026 03:19:19 +0000 [thread overview]
Message-ID: <sashiko-outbox-227669@kernel.org> (raw)
In-Reply-To: <20261122-nord_ep-v1-10-6d8839ffa9aa@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] bus: mhi: host: pci_generic: 0x0120 wildcard class matches
QCOM Root Port
- [Low] bus: mhi: host: pci_generic: unsorted PID 0x0120 entry in
mhi_pci_id_table
--
commit bf997d1ac5e3f263dea66560b3e85c9fdd9703e3
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
bus: mhi: host: pci_generic: Add support for Qualcomm Nord
This commit adds an MHI PCI device entry for the Qualcomm Nord endpoint
(device ID 0x0120), reusing the sa8775p MHI controller configuration.
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index ca9ef4aaa0140..65201ec8dc76c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
[ ... ]
> @@ -966,6 +977,8 @@ static const struct mhi_pci_dev_info mhi_netprisma_fcun69_info = {
> static const struct pci_device_id mhi_pci_id_table[] = {
> {PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0116),
> .driver_data = (kernel_ulong_t) &mhi_qcom_sa8775p_info },
> + {PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0120),
> + .driver_data = (kernel_ulong_t) &mhi_qcom_nord_info },
> /* Telit FN920C04 (sdx35) */
> {PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x011a, 0x1c5d, 0x2020),
> .driver_data = (kernel_ulong_t) &mhi_telit_fn920c04_info },
[Severity: Medium]
Does this match 17cb:0120 PCIe Root Ports in addition to the Nord MHI
endpoint?
Device ID 0x0120 is also used by Qualcomm Root Ports:
drivers/pci/quirks.c:pci_dev_acs_enabled() {
...
/* QCOM Glymur root port */
{ PCI_VENDOR_ID_QCOM, 0x0120, pci_quirk_qcom_rp_acs },
...
}
Because PCI_DEVICE() leaves .class and .class_mask at 0, udev autoloads
mhi_pci_generic for 17cb:0120 Root Ports, and if pcieport is not bound
(for example with CONFIG_PCIEPORTBUS=n or pcie_ports=compat),
mhi_pci_probe() binds to the Root Port bridge and tries to map BAR 1 as
MHI registers. Should this entry restrict .class and .class_mask to
match nord_header's PCI_CLASS_OTHERS?
[Severity: Low]
This isn't a bug, but the comment above mhi_pci_id_table asks to keep the
entries sorted by PID, so 0x0120 should go after the 0x011a entries.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-nord_ep-v1-0-6d8839ffa9aa@oss.qualcomm.com?part=10
next prev parent reply other threads:[~2026-11-22 3:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 2:56 [PATCH 00/11] PCI: qcom-ep: Add Nord PCIe Endpoint controller support Krishna Chaitanya Chundru
2026-11-22 2:56 ` [PATCH 01/11] PCI: epf-mhi: Pass the actual number of MSI vectors to pci_epc_set_msi() Krishna Chaitanya Chundru
2026-11-22 3:03 ` sashiko-bot
2026-11-22 2:56 ` [PATCH 02/11] PCI: qcom-ep: Add MSI-X support Krishna Chaitanya Chundru
2026-11-22 3:08 ` sashiko-bot
2026-11-22 2:56 ` [PATCH 03/11] PCI: epf-mhi: " Krishna Chaitanya Chundru
2026-11-22 3:15 ` sashiko-bot
2026-11-22 2:56 ` [PATCH 04/11] PCI: dwc: Preserve glue-provided eDMA HDMA channel separation Krishna Chaitanya Chundru
2026-11-22 2:56 ` [PATCH 05/11] phy: qcom: qmp-pcie: Add PCIe endpoint mode support Krishna Chaitanya Chundru
2026-11-22 2:56 ` [PATCH 06/11] phy: qcom: qmp-pcie: Add Nord endpoint mode init sequences Krishna Chaitanya Chundru
2026-11-22 2:56 ` [PATCH 07/11] dt-bindings: PCI: qcom-ep: Add Nord PCIe Endpoint Krishna Chaitanya Chundru
2026-11-22 2:56 ` [PATCH 08/11] PCI: qcom-ep: Add Nord PCIe Endpoint controller support Krishna Chaitanya Chundru
2026-11-22 3:08 ` sashiko-bot
2026-11-22 2:56 ` [PATCH 09/11] PCI: epf-mhi: Add Nord endpoint support Krishna Chaitanya Chundru
2026-11-22 2:56 ` [PATCH 10/11] bus: mhi: host: pci_generic: Add support for Qualcomm Nord Krishna Chaitanya Chundru
2026-11-22 3:19 ` sashiko-bot [this message]
2026-11-22 2:56 ` [PATCH 11/11] arm64: dts: qcom: nord: Add PCIe endpoint nodes Krishna Chaitanya Chundru
2026-11-22 3:17 ` sashiko-bot
2026-11-22 3:19 ` [PATCH 00/11] PCI: qcom-ep: Add Nord PCIe Endpoint controller support sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227669@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox