From: "tip-bot for Rafael J. Wysocki" <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: rafael.j.wysocki@intel.com, tglx@linutronix.de,
bhelgaas@google.com, hpa@zytor.com, mingo@kernel.org,
linux-pci@vger.kernel.org, dave.hansen@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: [tip:x86/urgent] x86 / PCI: Make broadcom_postcore_init() check acpi_disabled
Date: Mon, 4 Dec 2017 14:24:44 -0800 [thread overview]
Message-ID: <tip-2ee90363a838cf41ebf1ad24bad274762e467d8d@git.kernel.org> (raw)
In-Reply-To: <3186627.pxZj1QbYNg@aspire.rjw.lan>
Commit-ID: 2ee90363a838cf41ebf1ad24bad274762e467d8d
Gitweb: https://git.kernel.org/tip/2ee90363a838cf41ebf1ad24bad274762e467d8d
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
AuthorDate: Fri, 1 Dec 2017 15:08:12 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 4 Dec 2017 23:20:35 +0100
x86 / PCI: Make broadcom_postcore_init() check acpi_disabled
acpi_os_get_root_pointer() may return a valid address even if acpi_disabled
is set, but the host bridge information from the ACPI tables is not going
to be used in that case and the Broadcom host bridge initialization should
not be skipped then, So make broadcom_postcore_init() check acpi_disabled
too to avoid this issue.
Fixes: 6361d72b04d1 (x86/PCI: read Broadcom CNB20LE host bridge info before PCI scan)
Reported-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Linux PCI <linux-pci@vger.kernel.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/3186627.pxZj1QbYNg@aspire.rjw.lan
---
arch/x86/pci/broadcom_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/pci/broadcom_bus.c b/arch/x86/pci/broadcom_bus.c
index bb461cf..526536c 100644
--- a/arch/x86/pci/broadcom_bus.c
+++ b/arch/x86/pci/broadcom_bus.c
@@ -97,7 +97,7 @@ static int __init broadcom_postcore_init(void)
* We should get host bridge information from ACPI unless the BIOS
* doesn't support it.
*/
- if (acpi_os_get_root_pointer())
+ if (!acpi_disabled && acpi_os_get_root_pointer())
return 0;
#endif
next prev parent reply other threads:[~2017-12-04 22:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 14:01 [PATCH] x86 / PCI: Make broadcom_postcore_init() check acpi_disabled Rafael J. Wysocki
2017-12-01 14:08 ` Rafael J. Wysocki
2017-12-04 22:24 ` tip-bot for Rafael J. Wysocki [this message]
2017-12-06 11:35 ` [tip:x86/urgent] x86/PCI: " tip-bot for Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-2ee90363a838cf41ebf1ad24bad274762e467d8d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bhelgaas@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).