From: James Clark <james.clark@arm.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
cocci@inria.fr, linux-perf-users@vger.kernel.org,
spoorts2@in.ibm.com, kernel-janitors@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Ian Rogers <irogers@google.com>, Ingo Molnar <mingo@redhat.com>,
Jiri Olsa <jolsa@kernel.org>, Kajol Jain <kjain@linux.ibm.com>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] perf tests: Fix test_arm_callgraph_fp variable expansion
Date: Mon, 26 Jun 2023 09:09:23 +0100 [thread overview]
Message-ID: <0050f8d2-a4cd-2b84-77ad-6fa93bb14b16@arm.com> (raw)
In-Reply-To: <2b1cec46-52a9-21f1-bfcd-fbb4298f072a@web.de>
On 23/06/2023 17:56, Markus Elfring wrote:
> …
>> At the same time silence the shellcheck warning for that line and fix
>> two more shellcheck errors at the end of the script.
>
> Does such a wording really fit to the known requirement “Solve only one problem per patch.”?
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4-rc7#n81
>
>
> Regards,
> Markus
I think so, it fixes all the shellcheck errors that were claimed to be
fixed and introduced by the referenced fix.
To be honest I would have rather just reverted the original change
completely because it was obviously never tested.
prev parent reply other threads:[~2023-06-26 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 10:18 [PATCH] perf tests: Fix test_arm_callgraph_fp variable expansion James Clark
2023-06-23 5:00 ` Namhyung Kim
[not found] ` <2b1cec46-52a9-21f1-bfcd-fbb4298f072a@web.de>
2023-06-23 18:00 ` Namhyung Kim
2023-06-26 8:09 ` James Clark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0050f8d2-a4cd-2b84-77ad-6fa93bb14b16@arm.com \
--to=james.clark@arm.com \
--cc=Markus.Elfring@web.de \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=cocci@inria.fr \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=spoorts2@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).