Re: [PATCH] fix IPC output in perf intel-pt-events script

[Adrian Hunter <adrian.hunter@intel.com>]

On 10/03/23 13:10, Roman Lozko wrote:
> Integers are not converted to floats during division in Python 2
> which results in incorrect IPC values, convert to float explicitly.

Thanks for finding this.  Obviously Python 3 is preferred nowadays
but Python 2 seems to be still a thing.

AFAICT, it would be better to fix this by adding:

from __future__ import division

at the top of the script, next to from __future__ import print_function

Also the patch subject should be:

perf scripts: intel-pt-events.py: Fix IPC output for Python 2

Also a Fixes tag could be added i.e.

Fixes: a483e64c0b62 ("perf scripting python: intel-pt-events.py: Add --insn-trace and --src-trace")

> 
> Signed-off-by: Roman Lozko <lozko.roma@gmail.com>
> ---
>  tools/perf/scripts/python/intel-pt-events.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/scripts/python/intel-pt-events.py b/tools/perf/scripts/python/intel-pt-events.py
> index 08862a2582f4..26e840e17062 100644
> --- a/tools/perf/scripts/python/intel-pt-events.py
> +++ b/tools/perf/scripts/python/intel-pt-events.py
> @@ -269,7 +269,7 @@ def print_common_ip(param_dict, sample, symbol, dso):
>  	if "cyc_cnt" in sample:
>  		cyc_cnt = sample["cyc_cnt"]
>  		insn_cnt = get_optional_zero(sample, "insn_cnt")
> -		ipc_str = "  IPC: %#.2f (%u/%u)" % (insn_cnt / cyc_cnt, insn_cnt, cyc_cnt)
> +		ipc_str = "  IPC: %#.2f (%u/%u)" % (float(insn_cnt) / cyc_cnt, insn_cnt, cyc_cnt)
>  	else:
>  		ipc_str = ""
>  	if glb_insn and glb_disassembler is not None: