Re: [PATCH v7 0/4] Introduce perf check subcommand

[Athira Rajeev <atrajeev@linux.vnet.ibm.com>]

> On 17-Nov-2023, at 3:04 AM, Aditya Gupta <adityag@linux.ibm.com> wrote:
> 
> The Problem
> ===========
> 
> Currently the presence of a feature is checked with a combination of
> perf version --build-options and greps, such as:
> 
>    perf version --build-options | grep " on .* HAVE_FEATURE"
> 
> Proposed solution
> =================
> 
> As suggested by contributors in:
> https://lore.kernel.org/linux-perf-users/ZMPWk5K63tadmDlU@kernel.org/
> 
> Introduce a subcommand "perf check --feature", with which
> scripts can test for presence of a feature or multiple features, such as:
> 
>    perf check --feature HAVE_LIBTRACEEVENT
> 
>    or
> 
>    perf check --feature libtraceevent
> 
>    or
> 
>    perf check --feature libtraceevent,libbpf_support
> 
> The usage of "perf version --build-options | grep" has been replaced in two
> tests, with "perf check --feature" command
> 
> Also, to not duplicate the same feature list at multiple places, a new global
> 'supported_features' array has been introduced in builtin.h, so both commands
> 'perf check --feature' and 'perf version --build-options' use the same array
> 
> 'supported_features' feature is an array of 'struct feature_support', which
> also has the name of the feature, macro used to test it's presence, and a
> is_builtin member, which will be 0 if feature not built-in, and 1 if built-in

For the series, 

Reviewed-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>

Thanks
Athira
> Architectures Tested
> ====================
> * x86_64
> * ppc64le
> 
> Git tree
> ========
> 
> Git tree with this patch series applied for testing:
> https://github.com/adi-g15-ibm/linux/tree/perf-check-feature-v7
> 
> Changelog
> =========
> V7
> + modified patch #1 to fix compile issue, and add feature to allow
>  multiple comma-separated features
> 
> V6
> + rebased to perf-tools-next/perf-tools-next
> + modified patch #1 to include FEATURE_SUPPORT("bpf_skeletons", HAVE_BPF_SKEL)
> 
> V5
> + invert return value of 'has_support', but return value of perf check --feature
> according to shell convention
> 
> V4
> + invert return value of perf check --feature
> 
> V3
> + simplified has_support code in builtin-check.c (patch #1)
> + modified patch #3 and patch #4 according to change in return value in patch #1
> 
> V2
> + improved the patch series with suggestions from Namhyung
> + fix incorrect return value, added -q option, and moved array definition to
>  perf-check.c
> 
> V1
> + changed subcommand name to 'perf check --feature'
> + added documentation for perf check
> + support both macro (eg. HAVE_LIBTRACEEVENT), and name (eg. libtraceevent) as
>  input to 'perf check --feature'
> + change subject and descriptions of all patch mentioning perf check instead of
>  perf build
> 
> V0: Previous patch series: https://lore.kernel.org/linux-perf-users/20230825061125.24312-1-adityag@linux.ibm.com/
> 
> Aditya Gupta (3):
>  perf check: introduce check subcommand
>  perf version: update --build-options to use 'supported_features' array
>  perf tests task_analyzer: use perf check for libtraceevent support
> 
> Athira Rajeev (1):
>  tools/perf/tests: Update probe_vfs_getname.sh script to use perf check
>    --feature
> 
> tools/perf/Build                              |   1 +
> tools/perf/Documentation/perf-check.txt       |  59 +++++++++
> tools/perf/builtin-check.c                    | 122 ++++++++++++++++++
> tools/perf/builtin-version.c                  |  39 ++----
> tools/perf/builtin.h                          |  18 +++
> tools/perf/perf.c                             |   1 +
> .../perf/tests/shell/lib/probe_vfs_getname.sh |   4 +-
> .../shell/record+probe_libc_inet_pton.sh      |   5 +-
> .../shell/record+script_probe_vfs_getname.sh  |   5 +-
> tools/perf/tests/shell/test_task_analyzer.sh  |   4 +-
> 10 files changed, 221 insertions(+), 37 deletions(-)
> create mode 100644 tools/perf/Documentation/perf-check.txt
> create mode 100644 tools/perf/builtin-check.c
> 
> -- 
> 2.41.0
>