Re: [PATCH v3 2/2] perf tools annotate: Align the symbol_annotate return code

["Li, Tianyou" <tianyou.li@intel.com>]

Hi Namhyung,


On 10/20/2025 12:11 PM, Namhyung Kim wrote:
> On Mon, Oct 20, 2025 at 10:14:34AM +0800, Tianyou Li wrote:
>> Return error code from the symbol_annotate previously checks the
>> evsel__get_arch from '<0', now to '!=0'.
>>
>> Suggested-by: James Clark <james.clark@linaro.org>
>> Tested-by: Namhyung Kim <namhyung@kernel.org>
> This 'Tested-by' tag belongs to the patch 1 instead of this.  And you
> can add my ack here.
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Thanks,
> Namhyung
>

Thanks Namhyung, will send the patch v4 soon. Thanks.


>> Signed-off-by: Tianyou Li <tianyou.li@intel.com>
>> ---
>>   tools/perf/util/annotate.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
>> index 39d6594850f1..859e802a1e5e 100644
>> --- a/tools/perf/util/annotate.c
>> +++ b/tools/perf/util/annotate.c
>> @@ -1021,7 +1021,7 @@ int symbol__annotate(struct map_symbol *ms, struct evsel *evsel,
>>   	int err, nr;
>>   
>>   	err = evsel__get_arch(evsel, &arch);
>> -	if (err < 0)
>> +	if (err)
>>   		return err;
>>   
>>   	if (parch)
>> -- 
>> 2.47.1
>>