From: James Clark <james.clark@linaro.org>
To: Graham Woodward <graham.woodward@arm.com>
Cc: nd@arm.com, acme@kernel.org, namhyung@kernel.org,
mark.rutland@arm.com, jolsa@kernel.org, irogers@google.com,
mike.leach@linaro.org, leo.yan@linux.dev,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 0/4] perf arm-spe: Allow synthesizing of branch
Date: Mon, 28 Oct 2024 08:34:36 +0000 [thread overview]
Message-ID: <05c1d469-846b-457d-b4b9-216f8c7e33f1@linaro.org> (raw)
In-Reply-To: <20241025143009.25419-1-graham.woodward@arm.com>
On 25/10/2024 3:30 pm, Graham Woodward wrote:
> Currently the --itrace=b will only show branch-misses but this change
> allows perf to synthesize branches as well.
>
> The change also incorporates the ability to display the target
> addresses when specifying the addr field if the instruction is a branch.
>
> Graham Woodward (4):
> perf arm-spe: Set sample.addr to target address for instruction sample
> perf arm-spe: Use ARM_SPE_OP_BRANCH_ERET when synthesizing branches
> perf arm-spe: Correctly set sample flags
> perf arm-spe: Update --itrace help text
>
> tools/perf/Documentation/itrace.txt | 2 +-
> tools/perf/Documentation/perf-arm-spe.txt | 2 +-
> tools/perf/builtin-script.c | 1 +
> tools/perf/util/arm-spe.c | 31 ++++++++++++++++++-----
> tools/perf/util/auxtrace.h | 3 +--
> tools/perf/util/event.h | 1 +
> 6 files changed, 29 insertions(+), 11 deletions(-)
>
Don't forget to pickup the review tags from the previous versions. If
you use the b4 tool it does it automatically:
Reviewed-by: James Clark <james.clark@linaro.org>
next prev parent reply other threads:[~2024-10-28 8:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 14:30 [PATCH v1 0/4] perf arm-spe: Allow synthesizing of branch Graham Woodward
2024-10-25 14:30 ` [PATCH v1 1/4] perf arm-spe: Set sample.addr to target address for instruction sample Graham Woodward
2024-10-25 14:30 ` [PATCH v1 2/4] perf arm-spe: Use ARM_SPE_OP_BRANCH_ERET when synthesizing branches Graham Woodward
2024-10-25 14:30 ` [PATCH v1 3/4] perf arm-spe: Correctly set sample flags Graham Woodward
2024-10-25 14:30 ` [PATCH v1 4/4] perf arm-spe: Update --itrace help text Graham Woodward
2024-10-25 17:33 ` [PATCH v1 0/4] perf arm-spe: Allow synthesizing of branch Leo Yan
2024-10-28 8:34 ` James Clark [this message]
2024-10-28 16:40 ` Namhyung Kim
2024-10-29 17:03 ` Leo Yan
2024-10-29 23:09 ` Namhyung Kim
2024-10-30 9:33 ` Leo Yan
2024-10-30 21:30 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c1d469-846b-457d-b4b9-216f8c7e33f1@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=graham.woodward@arm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).