From: John Garry <john.g.garry@oracle.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Sumanth Korikkar <sumanthk@linux.ibm.com>,
Thomas Richter <tmricht@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v4] perf jevents: Parse metrics during conversion
Date: Wed, 7 Dec 2022 17:42:52 +0000 [thread overview]
Message-ID: <0d64e485-5acf-b7ad-e228-9bf85d8ae16d@oracle.com> (raw)
In-Reply-To: <Y5DQKif+PdRJblk+@kernel.org>
On 07/12/2022 17:40, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 06, 2022 at 09:59:08PM -0800, Ian Rogers escreveu:
>> Currently the 'MetricExpr' json value is passed from the json
>> file to the pmu-events.c. This change introduces an expression
>> tree that is parsed into. The parsing is done largely by using
>> operator overloading and python's 'eval' function. Two advantages
>> in doing this are:
> John, what tag can I get from you? 😄
>
> - Arnaldo
>
Sure,
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2022-12-07 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 5:59 [PATCH v4] perf jevents: Parse metrics during conversion Ian Rogers
2022-12-07 6:10 ` Ian Rogers
2022-12-07 13:11 ` Arnaldo Carvalho de Melo
2022-12-07 17:40 ` Arnaldo Carvalho de Melo
2022-12-07 17:42 ` John Garry [this message]
2022-12-07 17:46 ` Arnaldo Carvalho de Melo
2022-12-08 17:41 ` Ian Rogers
2022-12-12 15:46 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d64e485-5acf-b7ad-e228-9bf85d8ae16d@oracle.com \
--to=john.g.garry@oracle.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sumanthk@linux.ibm.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).