From: David Ahern <daahern@cisco.com>
To: linux-perf-users@vger.kernel.org
Cc: David Ahern <daahern@cisco.com>
Subject: [PATCH] perf symbols: reuse of name in dso__load when starting second pass
Date: Sun, 21 Nov 2010 08:03:50 -0700 [thread overview]
Message-ID: <1290351830-4398-1-git-send-email-daahern@cisco.com> (raw)
continue statement in default case applies when a second pass is
wanted as well. As it stands the code drops down to the open
re-using the value in name from the previous origin attempt.
Signed-off-by: David Ahern <daahern@cisco.com>
---
tools/perf/util/symbol.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index d30136e..861be8b 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1488,8 +1488,8 @@ int dso__load(struct dso *self, struct map *map, symbol_filter_t filter)
if (want_symtab) {
want_symtab = 0;
self->origin = DSO__ORIG_BUILD_ID_CACHE;
- } else
- continue;
+ }
+ continue;
}
/* Name is now the name of the next image to try */
--
1.7.2.3
next reply other threads:[~2010-11-21 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 15:03 David Ahern [this message]
2010-11-21 22:03 ` [PATCH] perf symbols: reuse of name in dso__load when starting second pass Arnaldo Carvalho de Melo
2010-11-22 0:50 ` David S. Ahern
2010-11-22 12:35 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290351830-4398-1-git-send-email-daahern@cisco.com \
--to=daahern@cisco.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).