linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: David Ahern <daahern@cisco.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	acme@ghostprotocols.net, mingo@elte.hu, fweisbec@gmail.com,
	paulus@samba.org, tglx@linutronix.de
Subject: Re: [PATCH 3/6] perf record: add time-of-day option
Date: Tue, 01 Mar 2011 23:28:09 +0100	[thread overview]
Message-ID: <1299018489.5226.940.camel@laptop> (raw)
In-Reply-To: <4D6D22A7.6000000@cisco.com>

On Tue, 2011-03-01 at 09:45 -0700, David Ahern wrote:

> One example would be a system watchdog that decided for some reason or
> another to force an event sample because of some event it detected.

That would be a design error, there already is an event, use that.

> > 
> > I'd much rather expose the whole
> > local_clock()/perf_clock()/trace_clock() (should all be the same anyway)
> > as a posix clock using CLOCK_TRACING or whatever would be an appropriate
> > name.
> > 
> > [ Since the whole thing is NMI safe it should be well possible to make a
> > VDSO version as well. ]
> > 
> > Anyway, once its visible as a posix clock you can sync up from
> > userspace. And this clock is indeed wanted for other things too, like
> > user-space tracing etc.
> > 
> 
> And for some silly reason I sense a time trap here (pun intended) .....
> 
> So your pushback is:
> 1. throw out the realtime-clock event patch,

Well, no, you need continues samples to keep in sync, so having this is
required [*].

> 2. add a new CLOCK_TRACING type to clock_gettime with VDSO hook,

Right, that is something we need anyway at some point in time.

> 3. and use a synthesized event from userspace for snapshotting
> perf_clock to time-of-day -- similar to what I have now, but one that
> will guarantee a time-of-day to perf_clock correlation (versus the
> current one which hopes that perf_clock is the monotonic clock).

I guess you could do that if we have full userspace tracing support, but
it wouldn't need synthesized events, it would need a pure userspace
event stream.

Thing is, I really dislike the ioctl() trigger

  parent reply	other threads:[~2011-03-01 22:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28  3:52 [PATCH 0/6 v3] perf events: Add realtime clock event, time-of-day strings to script output David Ahern
2011-02-28  3:52 ` [PATCH 1/6] perf events: Introduce realtime clock event David Ahern
2011-02-28  3:52 ` [PATCH 2/6] perf events: plumbing for PERF_SAMPLE_READ and read_format David Ahern
2011-02-28  3:52 ` [PATCH 3/6] perf record: add time-of-day option David Ahern
2011-03-01 14:29   ` Peter Zijlstra
2011-03-01 14:35     ` David Ahern
2011-03-01 15:35       ` Peter Zijlstra
2011-03-01 15:41         ` David Ahern
2011-03-01 16:00           ` Peter Zijlstra
2011-03-01 16:09             ` David Ahern
2011-03-01 16:37               ` Peter Zijlstra
2011-03-01 16:45                 ` David Ahern
2011-03-01 17:07                   ` Arnaldo Carvalho de Melo
2011-03-01 17:09                     ` Arnaldo Carvalho de Melo
2011-03-01 22:28                   ` Peter Zijlstra [this message]
2011-03-01 22:35                     ` David Ahern
2011-03-02 14:16   ` Thomas Gleixner
2011-03-02 14:28     ` David Ahern
2011-03-02 17:28       ` Thomas Gleixner
2011-03-03 14:29         ` David Ahern
2011-03-03  8:51       ` Ingo Molnar
2011-03-03 14:33         ` David Ahern
2011-02-28  3:52 ` [PATCH 4/6] perf script: dump software events too David Ahern
2011-03-01 14:09   ` Frederic Weisbecker
2011-03-01 14:18     ` David Ahern
2011-03-01 15:11       ` Frederic Weisbecker
2011-03-01 16:11         ` David Ahern
2011-03-01 16:24           ` Frederic Weisbecker
2011-03-01 16:49           ` Arnaldo Carvalho de Melo
2011-02-28  3:52 ` [PATCH 5/6] perf script: Prepend lines with time-of-day string David Ahern
2011-02-28  3:52 ` [PATCH 6/6] perf stat: treat realtime-clock as nsec counter David Ahern
2011-02-28  3:55 ` [PATCH 0/6 v3] perf events: Add realtime clock event, time-of-day strings to script output David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299018489.5226.940.camel@laptop \
    --to=peterz@infradead.org \
    --cc=acme@ghostprotocols.net \
    --cc=daahern@cisco.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).