linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arun Sharma <asharma@fb.com>
To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	acme@ghostprotocols.net
Cc: Arun Sharma <asharma@fb.com>
Subject: [PATCH] Add dso->deleted bit
Date: Tue, 10 May 2011 11:51:47 -0700	[thread overview]
Message-ID: <1305053507-28729-1-git-send-email-asharma@fb.com> (raw)

This keeps the knowledge about deleted filenames in one place.

Signed-off-by: Arun Sharma <asharma@fb.com>
---
 tools/perf/util/map.c    |    1 +
 tools/perf/util/symbol.c |    2 +-
 tools/perf/util/symbol.h |    1 +
 3 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index a16ecab..042ba9f 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -135,6 +135,7 @@ int map__load(struct map *self, symbol_filter_t filter)
 				   "a debug package?\n", name);
 		}
 
+		self->dso->deleted = 1;
 		return -1;
 	}
 	/*
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 17df793..dbd1944 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1575,7 +1575,7 @@ restart:
 	}
 
 	free(name);
-	if (ret < 0 && strstr(self->name, " (deleted)") != NULL)
+	if (ret < 0 && self->deleted)
 		return 0;
 	return ret;
 }
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
index 713b0b4..943a054 100644
--- a/tools/perf/util/symbol.h
+++ b/tools/perf/util/symbol.h
@@ -142,6 +142,7 @@ struct dso {
 	u8		 annotate_warned:1;
 	u8		 sname_alloc:1;
 	u8		 lname_alloc:1;
+	u8		 deleted:1;
 	unsigned char	 symtab_type;
 	u8		 sorted_by_name;
 	u8		 loaded;
-- 
1.7.4

                 reply	other threads:[~2011-05-10 18:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305053507-28729-1-git-send-email-asharma@fb.com \
    --to=asharma@fb.com \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).