From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arun Sharma <asharma@fb.com>,
avagin@gmail.com, linux-perf-users@vger.kernel.org,
acme@ghostprotocols.net, Stephane Eranian <eranian@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: Profiling sleep times?
Date: Sat, 15 Oct 2011 21:22:02 +0200 [thread overview]
Message-ID: <1318706522.2664.8.camel@laptop> (raw)
In-Reply-To: <20111015170044.GB29782@elte.hu>
On Sat, 2011-10-15 at 19:00 +0200, Ingo Molnar wrote:
> * Arun Sharma <asharma@fb.com> wrote:
>
> > On 10/12/11 12:41 AM, Ingo Molnar wrote:
> > >>Generally I'm happy with the direction of these patches. [...]
> > >
> > >Ok, will someone please send an updated series of all missing
> > >patches, with all acks included, for potential v3.2 pickup?
> > >
> > >Sleep time profiling is obviously a very hot feature ...
> > >
> >
> > I acked two of Andrew's patches. The third one is the most
> > important one. I haven't had a chance to review that carefully yet
> > - although it's working well for me.
> >
> > We still need to figure out what's the best way to munge all this
> > data in user space to implement wall clock profiling.
>
> Well, if 'perf report' can show sleep time ordered entries just fine
> by default (if a proper perf record was done), which also works in
> call graph recording mode then i'm a happy camper.
>
> Sleep time should really just be a different notion of 'cost of the
> function/callchain' and fit into the existing scheme, right?
The problem with andrew's patches is that it wrecks the callchain
semantics. The waittime tracepoint is in the wakeup path (and hence
generates the wakee's callchain) whereas they really want the callchain
of the woken task to show where it spend time.
next prev parent reply other threads:[~2011-10-15 19:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 19:38 Profiling sleep times? Arun Sharma
2011-10-03 20:17 ` Peter Zijlstra
2011-10-03 21:53 ` Arun Sharma
2011-10-04 8:34 ` Peter Zijlstra
2011-10-06 21:56 ` Arun Sharma
2011-10-07 0:05 ` Arun Sharma
2011-10-07 1:30 ` Peter Zijlstra
2011-10-07 5:42 ` avagin
2011-10-07 9:33 ` Peter Zijlstra
2011-10-07 17:58 ` Arun Sharma
2011-10-07 23:16 ` avagin
2011-10-08 1:45 ` avagin
2011-10-10 18:50 ` Arun Sharma
2011-10-12 7:41 ` Ingo Molnar
2011-10-13 5:39 ` Andrew Vagin
2011-10-14 21:19 ` Arun Sharma
2011-10-15 17:00 ` Ingo Molnar
2011-10-15 19:22 ` Peter Zijlstra [this message]
2011-10-15 19:29 ` Peter Zijlstra
2011-10-18 1:07 ` Arun Sharma
2011-10-22 10:49 ` Frederic Weisbecker
2011-10-22 16:22 ` Andrew Wagin
2011-10-23 0:27 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318706522.2664.8.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@ghostprotocols.net \
--cc=asharma@fb.com \
--cc=avagin@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).