From: Quentin Monnet <qmo@kernel.org>
To: Jiri Olsa <olsajiri@gmail.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, linux-perf-users@vger.kernel.org,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Hao Luo <haoluo@google.com>, Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [PATCH bpf-next 3/3] bpftool: Display ref_ctr_offset for uprobe link info
Date: Wed, 7 May 2025 10:40:31 +0100 [thread overview]
Message-ID: <1392a5c9-f67b-49fe-9f05-f2bc63fe01bb@kernel.org> (raw)
In-Reply-To: <aBsgQw1kzJsRzM5p@krava>
2025-05-07 10:56 UTC+0200 ~ Jiri Olsa <olsajiri@gmail.com>
> On Tue, May 06, 2025 at 03:33:33PM -0700, Andrii Nakryiko wrote:
>> On Tue, May 6, 2025 at 6:58 AM Jiri Olsa <jolsa@kernel.org> wrote:
>>>
>>> Adding support to display ref_ctr_offset in link output, like:
>>>
>>> # bpftool link
>>> ...
>>> 42: perf_event prog 174
>>> uprobe /proc/self/exe+0x102f13 cookie 3735928559 ref_ctr_offset 50500538
>>
>> let's use hex for ref_ctr_offset?
>
> I had that, then I saw cookie was dec ;-) either way is fine for me
I'm fine either way, but let's use the same base for the two values
please. If you want to change the cookie to hexa (in the plain output)
for better readability, that's OK as well (JSON output needs to remain a
decimal in both cases, of course).
Quentin
next prev parent reply other threads:[~2025-05-07 9:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 13:57 [PATCH bpf-next 0/3] bpf: Retrieve ref_ctr_offset from uprobe perf link Jiri Olsa
2025-05-06 13:57 ` [PATCH bpf-next 1/3] bpf: Add support to retrieve ref_ctr_offset for " Jiri Olsa
2025-05-07 2:18 ` Yafang Shao
2025-05-06 13:57 ` [PATCH bpf-next 2/3] selftests/bpf: Add link info test for ref_ctr_offset retrieval Jiri Olsa
2025-05-07 2:26 ` Yafang Shao
2025-05-06 13:57 ` [PATCH bpf-next 3/3] bpftool: Display ref_ctr_offset for uprobe link info Jiri Olsa
2025-05-06 14:28 ` Quentin Monnet
2025-05-06 22:33 ` Andrii Nakryiko
2025-05-07 8:56 ` Jiri Olsa
2025-05-07 9:40 ` Quentin Monnet [this message]
2025-05-07 18:18 ` Andrii Nakryiko
2025-05-07 19:35 ` Quentin Monnet
2025-05-09 15:30 ` Jiri Olsa
2025-05-09 15:54 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392a5c9-f67b-49fe-9f05-f2bc63fe01bb@kernel.org \
--to=qmo@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=laoar.shao@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=olsajiri@gmail.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).