From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: acme@redhat.com, namhyung@kernel.org, jolsa@kernel.org
Cc: peterz@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arch@vger.kernel.org, Alexey.Brodkin@synopsys.com,
Borislav Petkov <bp@suse.de>, Cody P Schafer <dev@codyps.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>
Subject: [PATCH v3 1/5] perf tools: [uclibc] fix statfs.f_type data type mismatch build error
Date: Tue, 13 Jan 2015 19:13:20 +0530 [thread overview]
Message-ID: <1421156604-30603-2-git-send-email-vgupta@synopsys.com> (raw)
In-Reply-To: <1421156604-30603-1-git-send-email-vgupta@synopsys.com>
From: Alexey Brodkin <abrodkin@synopsys.com>
ARC Linux uses the no legacy syscalls abi and corresponding uClibc headers
statfs defines f_type to be U32 which causes perf build breakage
http://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common-generic/bits/statfs.h
----------->8---------------
CC fs/fs.o
fs/fs.c: In function 'fs__valid_mount':
fs/fs.c:82:24: error: comparison between signed and unsigned integer
expressions [-Werror=sign-compare]
else if (st_fs.f_type != magic)
^
cc1: all warnings being treated as errors
----------->8---------------
Cc: Borislav Petkov <bp@suse.de>
Cc: Cody P Schafer <dev@codyps.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Acked-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
---
v4:
* Add Ack from Jiri Olsa
v3: Changes since v2 [2]
* Made Changelog a bit more concise, no code changes [vgupta]
v2: Changes since v1 [1]
* Added type cast to DEBUGFS_MAGIC in "debugfs.c" [Arnaldo]
* Added verbose explanation of root cause
[2] https://lkml.org/lkml/2014/9/16/296
[1] https://lkml.org/lkml/2014/8/13/529
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
tools/lib/api/fs/debugfs.c | 2 +-
tools/lib/api/fs/fs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c
index a74fba6d7743..93aa4cd2416f 100644
--- a/tools/lib/api/fs/debugfs.c
+++ b/tools/lib/api/fs/debugfs.c
@@ -67,7 +67,7 @@ int debugfs_valid_mountpoint(const char *debugfs)
if (statfs(debugfs, &st_fs) < 0)
return -ENOENT;
- else if (st_fs.f_type != (long) DEBUGFS_MAGIC)
+ else if ((long) st_fs.f_type != (long) DEBUGFS_MAGIC)
return -ENOENT;
return 0;
diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c
index 65d9be3f9887..15e64921ea84 100644
--- a/tools/lib/api/fs/fs.c
+++ b/tools/lib/api/fs/fs.c
@@ -79,7 +79,7 @@ static int fs__valid_mount(const char *fs, long magic)
if (statfs(fs, &st_fs) < 0)
return -ENOENT;
- else if (st_fs.f_type != magic)
+ else if ((long) st_fs.f_type != magic)
return -ENOENT;
return 0;
--
1.9.1
next prev parent reply other threads:[~2015-01-13 13:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 13:43 [PATCH v3 0/5] Perf tool fixes for ARC + uClibc Vineet Gupta
2015-01-13 13:43 ` Vineet Gupta [this message]
2015-01-13 13:43 ` [PATCH v3 2/5] perf tools: [uclibc] Elide strlcpy warning Vineet Gupta
2015-01-13 13:43 ` [PATCH v3 3/5] perf tools: [uclibc] Avoid build splat for syscall numbers Vineet Gupta
2015-01-13 13:43 ` [PATCH v3 4/5] perf tools: [uclibc] don't rely on glibc malloc working for sz 0 Vineet Gupta
2015-01-13 13:43 ` [PATCH v3 5/5] perf tools: [uclibc] provide stub for pthread_attr_setaffinity_np Vineet Gupta
2015-01-14 12:00 ` [PATCH v3 0/5] Perf tool fixes for ARC + uClibc Jiri Olsa
2015-01-14 13:59 ` Arnaldo Carvalho de Melo
2015-01-19 4:35 ` Vineet Gupta
2015-01-19 13:58 ` Arnaldo Carvalho de Melo
2015-01-27 10:29 ` Vineet Gupta
2015-01-27 14:29 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421156604-30603-2-git-send-email-vgupta@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=acme@redhat.com \
--cc=bp@suse.de \
--cc=dev@codyps.com \
--cc=jolsa@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).