From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Cc: daniel.sneddon@linux.intel.com, tony.luck@intel.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-perf-users@vger.kernel.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>
Subject: Re: [PATCH PATCH 8/9] x86/bugs: Declutter vulnerable CPU list
Date: Mon, 17 Jun 2024 10:38:32 +0100 [thread overview]
Message-ID: <14d5ed1b-db72-4676-bce2-1ff3637a7e56@citrix.com> (raw)
In-Reply-To: <20240617-add-cpu-type-v1-8-b88998c01e76@linux.intel.com>
On 17/06/2024 10:12 am, Pawan Gupta wrote:
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index d4e539d4e158..7e3b09b0f82c 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -1229,43 +1232,45 @@ static const __initconst struct x86_cpu_id cpu_vuln_whitelist[] = {
> #define RFDS BIT(7)
>
> static const struct x86_cpu_id cpu_vuln_blacklist[] __initconst = {
> - VULNBL_INTEL_STEPPINGS(INTEL_IVYBRIDGE, X86_STEPPING_ANY, SRBDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_HASWELL, X86_STEPPING_ANY, SRBDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_HASWELL_L, X86_STEPPING_ANY, SRBDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_HASWELL_G, X86_STEPPING_ANY, SRBDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_HASWELL_X, X86_STEPPING_ANY, MMIO),
> - VULNBL_INTEL_STEPPINGS(INTEL_BROADWELL_D, X86_STEPPING_ANY, MMIO),
> - VULNBL_INTEL_STEPPINGS(INTEL_BROADWELL_G, X86_STEPPING_ANY, SRBDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_BROADWELL_X, X86_STEPPING_ANY, MMIO),
> - VULNBL_INTEL_STEPPINGS(INTEL_BROADWELL, X86_STEPPING_ANY, SRBDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_SKYLAKE_X, X86_STEPPING_ANY, MMIO | RETBLEED | GDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_SKYLAKE_L, X86_STEPPING_ANY, MMIO | RETBLEED | GDS | SRBDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_SKYLAKE, X86_STEPPING_ANY, MMIO | RETBLEED | GDS | SRBDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_KABYLAKE_L, X86_STEPPING_ANY, MMIO | RETBLEED | GDS | SRBDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_KABYLAKE, X86_STEPPING_ANY, MMIO | RETBLEED | GDS | SRBDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_CANNONLAKE_L, X86_STEPPING_ANY, RETBLEED),
> - VULNBL_INTEL_STEPPINGS(INTEL_ICELAKE_L, X86_STEPPING_ANY, MMIO | MMIO_SBDS | RETBLEED | GDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ICELAKE_D, X86_STEPPING_ANY, MMIO | GDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ICELAKE_X, X86_STEPPING_ANY, MMIO | GDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_COMETLAKE, X86_STEPPING_ANY, MMIO | MMIO_SBDS | RETBLEED | GDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_COMETLAKE_L, X86_STEPPINGS(0x0, 0x0), MMIO | RETBLEED),
> - VULNBL_INTEL_STEPPINGS(INTEL_COMETLAKE_L, X86_STEPPING_ANY, MMIO | MMIO_SBDS | RETBLEED | GDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_TIGERLAKE_L, X86_STEPPING_ANY, GDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_TIGERLAKE, X86_STEPPING_ANY, GDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_LAKEFIELD, X86_STEPPING_ANY, MMIO | MMIO_SBDS | RETBLEED),
> - VULNBL_INTEL_STEPPINGS(INTEL_ROCKETLAKE, X86_STEPPING_ANY, MMIO | RETBLEED | GDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ALDERLAKE, X86_STEPPING_ANY, RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ALDERLAKE_L, X86_STEPPING_ANY, RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_RAPTORLAKE, X86_STEPPING_ANY, RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_RAPTORLAKE_P, X86_STEPPING_ANY, RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_RAPTORLAKE_S, X86_STEPPING_ANY, RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ATOM_GRACEMONT, X86_STEPPING_ANY, RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ATOM_TREMONT, X86_STEPPING_ANY, MMIO | MMIO_SBDS | RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ATOM_TREMONT_D, X86_STEPPING_ANY, MMIO | RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ATOM_TREMONT_L, X86_STEPPING_ANY, MMIO | MMIO_SBDS | RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ATOM_GOLDMONT, X86_STEPPING_ANY, RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ATOM_GOLDMONT_D, X86_STEPPING_ANY, RFDS),
> - VULNBL_INTEL_STEPPINGS(INTEL_ATOM_GOLDMONT_PLUS, X86_STEPPING_ANY, RFDS),
> + VULNBL_INTEL(IVYBRIDGE, SRBDS),
> + VULNBL_INTEL(HASWELL, SRBDS),
> + VULNBL_INTEL(HASWELL_L, SRBDS),
> + VULNBL_INTEL(HASWELL_G, SRBDS),
> + VULNBL_INTEL(HASWELL_X, MMIO),
> + VULNBL_INTEL(BROADWELL_D, MMIO),
> + VULNBL_INTEL(BROADWELL_G, SRBDS),
> + VULNBL_INTEL(BROADWELL_X, MMIO),
> + VULNBL_INTEL(BROADWELL, SRBDS),
> + VULNBL_INTEL(SKYLAKE_X, MMIO | RETBLEED | GDS),
> + VULNBL_INTEL(SKYLAKE_L, MMIO | RETBLEED | GDS | SRBDS),
> + VULNBL_INTEL(SKYLAKE, MMIO | RETBLEED | GDS | SRBDS),
> + VULNBL_INTEL(KABYLAKE_L, MMIO | RETBLEED | GDS | SRBDS),
> + VULNBL_INTEL(KABYLAKE, MMIO | RETBLEED | GDS | SRBDS),
> + VULNBL_INTEL(CANNONLAKE_L, RETBLEED),
> + VULNBL_INTEL(ICELAKE_L, MMIO | MMIO_SBDS | RETBLEED | GDS),
> + VULNBL_INTEL(ICELAKE_D, MMIO | GDS),
> + VULNBL_INTEL(ICELAKE_X, MMIO | GDS),
> + VULNBL_INTEL(COMETLAKE, MMIO | MMIO_SBDS | RETBLEED | GDS),
> + VULNBL_INTEL(TIGERLAKE_L, GDS),
> + VULNBL_INTEL(TIGERLAKE, GDS),
> + VULNBL_INTEL(LAKEFIELD, MMIO | MMIO_SBDS | RETBLEED),
> + VULNBL_INTEL(ROCKETLAKE, MMIO | RETBLEED | GDS),
> + VULNBL_INTEL(ALDERLAKE, RFDS),
> + VULNBL_INTEL(ALDERLAKE_L, RFDS),
> + VULNBL_INTEL(RAPTORLAKE, RFDS),
> + VULNBL_INTEL(RAPTORLAKE_P, RFDS),
> + VULNBL_INTEL(RAPTORLAKE_S, RFDS),
> + VULNBL_INTEL(ATOM_GRACEMONT, RFDS),
> + VULNBL_INTEL(ATOM_TREMONT, MMIO | MMIO_SBDS | RFDS),
> + VULNBL_INTEL(ATOM_TREMONT_D, MMIO | RFDS),
> + VULNBL_INTEL(ATOM_TREMONT_L, MMIO | MMIO_SBDS | RFDS),
> + VULNBL_INTEL(ATOM_GOLDMONT, RFDS),
> + VULNBL_INTEL(ATOM_GOLDMONT_D, RFDS),
> + VULNBL_INTEL(ATOM_GOLDMONT_PLUS, RFDS),
Take the opportunity to realign and fix this ?
~Andrew
next prev parent reply other threads:[~2024-06-17 9:38 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 9:11 [PATCH 0/9] Add CPU-type to topology Pawan Gupta
2024-06-17 9:11 ` [PATCH PATCH 1/9] x86/cpu/topology: Add x86_cpu_type to struct cpuinfo_topology Pawan Gupta
2024-06-17 9:35 ` Andrew Cooper
2024-06-17 17:51 ` Pawan Gupta
2024-06-17 13:24 ` kernel test robot
2024-06-17 13:45 ` kernel test robot
2024-06-18 21:28 ` Borislav Petkov
2024-06-19 3:31 ` Pawan Gupta
2024-06-20 15:51 ` Borislav Petkov
2024-06-21 6:36 ` Pawan Gupta
2024-06-18 21:33 ` Mario Limonciello
2024-06-18 22:03 ` Dave Hansen
2024-06-17 9:11 ` [PATCH PATCH 2/9] cpufreq: intel_pstate: Use topology_cpu_type() to get cpu-type Pawan Gupta
2024-06-17 9:27 ` srinivas pandruvada
2024-06-17 18:36 ` Pawan Gupta
2024-06-17 14:01 ` kernel test robot
2024-06-17 9:11 ` [PATCH PATCH 3/9] perf/x86/intel: " Pawan Gupta
2024-06-17 14:50 ` Dave Hansen
2024-06-17 18:09 ` Pawan Gupta
2024-06-17 18:17 ` Dave Hansen
2024-06-17 18:25 ` Pawan Gupta
2024-06-17 9:11 ` [PATCH PATCH 4/9] x86/cpu: Remove get_this_hybrid_cpu_type() Pawan Gupta
2024-06-17 9:11 ` [PATCH PATCH 5/9] x86/cpu: Name CPU matching macro more generically (and shorten) Pawan Gupta
2024-06-17 9:11 ` [PATCH PATCH 6/9] x86/cpu: Add cpu_type to struct x86_cpu_id Pawan Gupta
2024-06-17 9:12 ` [PATCH PATCH 7/9] x86/cpu: Update x86_match_cpu() to also use cpu-type Pawan Gupta
2024-06-17 9:12 ` [PATCH PATCH 8/9] x86/bugs: Declutter vulnerable CPU list Pawan Gupta
2024-06-17 9:38 ` Andrew Cooper [this message]
2024-06-17 18:13 ` Pawan Gupta
2024-06-17 14:13 ` Dave Hansen
2024-06-17 18:14 ` Pawan Gupta
2024-06-17 23:52 ` Pawan Gupta
2024-06-18 0:08 ` Luck, Tony
2024-06-18 3:19 ` Pawan Gupta
2024-06-17 9:12 ` [PATCH PATCH 9/9] x86/rfds: Exclude P-only parts from the RFDS affected list Pawan Gupta
2024-06-17 9:43 ` Andrew Cooper
2024-06-17 14:34 ` Dave Hansen
2024-06-17 18:19 ` Pawan Gupta
2024-06-17 14:33 ` Dave Hansen
2024-06-17 18:24 ` Pawan Gupta
2024-06-18 12:49 ` [PATCH 0/9] Add CPU-type to topology Brice Goglin
2024-06-19 1:53 ` Pawan Gupta
2024-06-19 10:34 ` srinivas pandruvada
2024-06-19 21:25 ` Brice Goglin
2024-06-20 15:06 ` Dave Hansen
2024-06-20 15:22 ` Brice Goglin
2024-06-21 6:23 ` Pawan Gupta
2024-06-27 12:55 ` Ricardo Neri
2024-06-27 12:51 ` Ricardo Neri
2024-06-27 13:22 ` Pawan Gupta
2024-06-27 15:26 ` Ricardo Neri
2024-06-27 16:54 ` Liang, Kan
2024-06-29 11:37 ` Brice Goglin
2024-06-27 12:53 ` Ricardo Neri
2024-06-19 21:22 ` Brice Goglin
2024-06-27 15:22 ` Ricardo Neri
2024-06-27 15:22 ` Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14d5ed1b-db72-4676-bce2-1ff3637a7e56@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=rafael@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).