From: "Paul A. Clarke" <pc@us.ibm.com>
To: linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, acme@kernel.org,
ananth@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com,
naveen.n.rao@linux.vnet.ibm.com, sukadev@linux.ibm.com,
mpe@ellerman.id.au, irogers@google.com
Subject: [PATCH 1/2] perf: Fix POWER9 metric 'lsu_other_stall_cpi'
Date: Thu, 7 May 2020 11:28:57 -0500 [thread overview]
Message-ID: <1588868938-21933-2-git-send-email-pc@us.ibm.com> (raw)
In-Reply-To: <1588868938-21933-1-git-send-email-pc@us.ibm.com>
From: "Paul A. Clarke" <pc@us.ibm.com>
The metric definition is too long for the current value of EXPR_MAX_OTHER.
Increase the value EXPR_MAX_OTHER sufficiently to allow
'lsu_other_stall_cpi' to build properly.
Before:
--
$ perf list | grep lsu_other
lsu_other_stall_cpi
# perf stat -a --metrics lsu_other_stall_cpi /bin/sleep 1
Cannot find metric or group `lsu_other_stall_cpi'
Usage: perf stat [<options>] [<command>]
-M, --metrics <metric/metric group list>
monitor specified metrics or metric groups (separated by ,)
--
After:
--
# perf stat -a --metrics lsu_other_stall_cpi /bin/sleep 1
Performance counter stats for 'system wide':
438,086,889 pm_cmplu_stall_lsu # 1.74 lsu_other_stall_cpi
[...]
--
Signed-off-by: Paul A. Clarke <pc@us.ibm.com>
---
tools/perf/util/expr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h
index 87d627bb699b..a0991959cca4 100644
--- a/tools/perf/util/expr.h
+++ b/tools/perf/util/expr.h
@@ -2,7 +2,7 @@
#ifndef PARSE_CTX_H
#define PARSE_CTX_H 1
-#define EXPR_MAX_OTHER 20
+#define EXPR_MAX_OTHER 28
#define MAX_PARSE_ID EXPR_MAX_OTHER
struct expr_parse_id {
--
2.18.2
next prev parent reply other threads:[~2020-05-07 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 16:28 [PATCH 0/2] perf: Fix POWER9 cpi_breakdown metricgroup Paul A. Clarke
2020-05-07 16:28 ` Paul A. Clarke [this message]
2020-05-07 16:48 ` [PATCH 1/2] perf: Fix POWER9 metric 'lsu_other_stall_cpi' Arnaldo Carvalho de Melo
2020-05-07 17:21 ` Ian Rogers
2020-05-08 6:31 ` kajoljain
2020-05-08 7:01 ` kajoljain
2020-05-07 16:28 ` [PATCH 2/2] perf: Add missing metrics to POWER9 'cpi_breakdown' Paul A. Clarke
2020-05-07 16:57 ` Arnaldo Carvalho de Melo
2020-05-08 7:04 ` kajoljain
2020-05-10 6:26 ` Ian Rogers
2020-05-11 15:29 ` Arnaldo Carvalho de Melo
2020-05-13 8:28 ` Michael Ellerman
2020-05-14 21:04 ` Paul A. Clarke
2020-05-16 12:03 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588868938-21933-2-git-send-email-pc@us.ibm.com \
--to=pc@us.ibm.com \
--cc=acme@kernel.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=sukadev@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).